[jira] [Commented] (MDEP-980) ConstantPoolParser throws raw RuntimeException

["Slawomir Jaranowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MDEP-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945684#comment-17945684 ] 

Slawomir Jaranowski commented on MDEP-980:
------------------------------------------

This class is in {{maven-dependency-analyzer}} project - right?
If true we should create issue in correct project.

> ConstantPoolParser throws raw RuntimeException
> ----------------------------------------------
>
>                 Key: MDEP-980
>                 URL: https://issues.apache.org/jira/browse/MDEP-980
>             Project: Maven Dependency Plugin
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Minor
>
> from parseConstantPoolClassReferences which is reading external data (.class files specifically) so this really should be a checked exception, but even if we leave it a runtime exception it should be a more semantically meaningful subclass per Effective Java. Maybe something like java.io.InvalidClassException?
> Furthermore, it's a bug because the code in visitClass that ultimately invokes this private method does not catch RuntimeException, only more specific subclasses like IllegalArgumenException. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)