You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lkokhreidze (via GitHub)" <gi...@apache.org> on 2023/10/22 12:42:03 UTC
[PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
lkokhreidze opened a new pull request, #14608:
URL: https://github.com/apache/kafka/pull/14608
Trying to fix flakiness for the `shouldInvokeUserDefinedGlobalStateRestoreListener` test introduced in https://github.com/apache/kafka/pull/14519.
Fixes are:
1. Do not use static membership.
2. Always close the 2nd KafkaStreams instance.
3. Await for the Kafka Streams instance to transition to a RUNNING state before proceeding.
4. Added logging for the `StateRestoreListener` implementation
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman merged PR #14608:
URL: https://github.com/apache/kafka/pull/14608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
Posted by "lkokhreidze (via GitHub)" <gi...@apache.org>.
lkokhreidze commented on PR #14608:
URL: https://github.com/apache/kafka/pull/14608#issuecomment-1780501625
Ping @cadonna @ableegoldman in case this PR got lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #14608:
URL: https://github.com/apache/kafka/pull/14608#issuecomment-1781945353
Test failures are unrelated, and the relevant test passed in all cases, so let's merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
Posted by "lkokhreidze (via GitHub)" <gi...@apache.org>.
lkokhreidze commented on PR #14608:
URL: https://github.com/apache/kafka/pull/14608#issuecomment-1774835673
Please review @cadonna @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on code in PR #14608:
URL: https://github.com/apache/kafka/pull/14608#discussion_r1373854238
##########
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -523,13 +527,13 @@ public void shouldInvokeUserDefinedGlobalStateRestoreListener() throws Exception
final Map<String, Object> kafkaStreams1Configuration = mkMap(
mkEntry(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory(appId).getPath() + "-ks1"),
- mkEntry(StreamsConfig.consumerPrefix(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG), appId + "-ks1"),
Review Comment:
ah, yeah, good catch -- we should definitely not be using the `group.instance.id` config in tests, it turns on static membership which will delay the test at best (and mess with it at worst)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15659: Fix shouldInvokeUserDefinedGlobalStateRestoreListener flaky test [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on code in PR #14608:
URL: https://github.com/apache/kafka/pull/14608#discussion_r1373854238
##########
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -523,13 +527,13 @@ public void shouldInvokeUserDefinedGlobalStateRestoreListener() throws Exception
final Map<String, Object> kafkaStreams1Configuration = mkMap(
mkEntry(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory(appId).getPath() + "-ks1"),
- mkEntry(StreamsConfig.consumerPrefix(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG), appId + "-ks1"),
Review Comment:
ah, yeah, good catch -- we should definitely not be using the `group.instance.id` config in tests, turning on static membership will delay the test at best (and mess with it at worst)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org