You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by markito <gi...@git.apache.org> on 2017/03/28 19:53:50 UTC

[GitHub] zeppelin pull request #2199: [ZEPPELIN-2326] - Updating Geode dependencies a...

GitHub user markito opened a pull request:

    https://github.com/apache/zeppelin/pull/2199

    [ZEPPELIN-2326] - Updating Geode dependencies and imports due to package rename

    ### What is this PR for?
    Updating Geode dependencies and imports due to package rename - ZEPPELIN-2326
    
    ### What type of PR is it?
    Refactoring
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2326
    
    ### How should this be tested?
    Same tests. One test (`oqlPdxInstanceResponse`) was failing before this change and it's still failing...  Looks like a problem with the mock response, but I've not looked further. All remaining tests are passing.
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markito/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2199
    
----
commit ededffba4403c763257e472779cf0b56659a62ae
Author: William Markito Oliveira <ma...@apache.org>
Date:   2017-03-28T19:45:03Z

    Updating Geode dependencies and imports due to package rename

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by markito <gi...@git.apache.org>.

Github user markito commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    @1ambda indeed! I've restarted the CI job and now it's all green! https://travis-ci.org/markito/zeppelin/builds/216598188


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    looks good, could you please setup CI as referenced here https://zeppelin.apache.org/contribution/contributions.html#continuous-integration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    Merge into master and branch-0.7 if there are no more comments on this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by markito <gi...@git.apache.org>.

Github user markito commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    I'm sorry, skipped that part from the contribution guide. Will do and amend. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by markito <gi...@git.apache.org>.

Github user markito commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    @1ambda can you please confirm if the reopened JIRA triggered Jenkins properly ?  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    CI is green now. LGTM 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    Hi @markito Thanks for your contribution and taking care of Geode interpreter. 
    
     - Zeppelin build system relies on travis. So please setup your travis account and travis project for Zeppelin.
     - Please take a look https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
     - The repository name must be Zeppelin (not incubator-zeppelin, ...)
     - It's not mandatory to pass all tests to be reviewed. But some reviewers might select passed PRs first
    
    Trigger travis CI by pushing new commits or amend your last commit (git commit --amend and git push your-remote HEAD --force) after setup your travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    I am not sure but the failed test is due to one of flaky tests. Please restart it.
    
    ```
    
    Results :
    
    Tests in error: 
      InterpreterIT.testShowDescriptionOnInterpreterCreate:69 » ElementNotVisible El...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Posted by markito <gi...@git.apache.org>.

Github user markito commented on the issue:

    https://github.com/apache/zeppelin/pull/2199
  
    No problem, just reopened.... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---