[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #2217: [TINKERPOP-2972] ProjectStep does not allow keys specified in a query

["xiazcy (via GitHub)" <gi...@apache.org>]

xiazcy commented on code in PR #2217:
URL: https://github.com/apache/tinkerpop/pull/2217#discussion_r1319202940


##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Project.feature:
##########
@@ -106,4 +106,13 @@ Feature: Step - project()
       | m[{"a":"d[0].l", "b":"d[29].i"}] |
       | m[{"a":"d[1].l", "b":"d[27].i"}] |
       | m[{"a":"d[1].l", "b":"d[32].i"}] |
-      | m[{"a":"d[0].l", "b":"d[35].i"}] |
\ No newline at end of file
+      | m[{"a":"d[0].l", "b":"d[35].i"}] |
+
+
+  Scenario: g_V_projectXa_aX

Review Comment:
   Looks like the Gherkin tests can't handle cases that fast fail on step construction (I believe it needs the step to be successfully constructed before translating it into the GLV tests). I don't think there is any easy work around currently, sorry @rdtr, you might need to remove this test and just have unit tests.
   
   (As an aside, the test is missing a `When iterated to list`, but that's not really important now that this test won't really work in Gherkin).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org