You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/05 07:39:55 UTC
[GitHub] zeppelin pull request #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium pa...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2224
[ZEPPELIN-2304] Fix vis Icon sizes in helium page (branch-0.7)
### What is this PR for?
Icon size of helium vis packages doesn't fit into the container button. I attached a image.
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2304](https://issues.apache.org/jira/browse/ZEPPELIN-2304)
### How should this be tested?
1. Install 2+ vis packages.
2. Open the `#helium` page
### Screenshots (if appropriate)
#### Before
<img width="378" alt="2304_before" src="https://cloud.githubusercontent.com/assets/4968473/24238569/17b7dbaa-0fee-11e7-9994-39fd7700c70c.png">
#### After
<img width="389" alt="2304_after" src="https://cloud.githubusercontent.com/assets/4968473/24238572/1aac7b72-0fee-11e7-934d-da4c2d864b54.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2304/fix-vis-icon-size-in-helium-page-for-072
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2224
----
commit 9853730387d1d529f3b8ecad79801400c2303eb0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-05T07:38:41Z
fix: Vis icon size in helium.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2224
CI is green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2224
LGTM
Merge into branch-0.7 if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium pa...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2224
@1ambda I just merged this into branch-0.7 but it's not closed automatically. Could you close in your side?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2224
@AhyoungRyu Could you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2224
CI failure is irrelevant with this change. Looks good :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium pa...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2224
[ZEPPELIN-2304] Fix vis Icon sizes in helium page (branch-0.7)
### What is this PR for?
Icon size of helium vis packages doesn't fit into the container button. I attached a image.
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2304](https://issues.apache.org/jira/browse/ZEPPELIN-2304)
### How should this be tested?
1. Install 2+ vis packages.
2. Open the `#helium` page
### Screenshots (if appropriate)
#### Before
<img width="378" alt="2304_before" src="https://cloud.githubusercontent.com/assets/4968473/24238569/17b7dbaa-0fee-11e7-9994-39fd7700c70c.png">
#### After
<img width="389" alt="2304_after" src="https://cloud.githubusercontent.com/assets/4968473/24238572/1aac7b72-0fee-11e7-934d-da4c2d864b54.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2304/fix-vis-icon-size-in-helium-page-for-072
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2224
----
commit 9853730387d1d529f3b8ecad79801400c2303eb0
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-05T07:38:41Z
fix: Vis icon size in helium.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium pa...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---