You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by mat-ale <gi...@git.apache.org> on 2017/06/27 07:42:21 UTC
[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]
GitHub user mat-ale opened a pull request:
https://github.com/apache/syncope/pull/47
Fixes [SYNCOPE-1110], [SYNCOPE-1123]
Hi,
this fixes [[SYNCOPE-1110]](https://issues.apache.org/jira/browse/SYNCOPE-1110) and [[SYNCOPE-1123]](https://issues.apache.org/jira/browse/SYNCOPE-1123).
Regards,
Matteo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mat-ale/syncope SYNCOPE-1110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit abbed772c8f2723ffc002a480f3f20600650128d
Author: Matteo Alessandroni <ma...@tirasa.net>
Date: 2017-06-23T12:27:17Z
Fixes [SYNCOPE-1110], [SYNCOPE-1123]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/47#discussion_r124200072
--- Diff: fit/enduser-reference/src/test/resources/protractor-conf.js ---
@@ -19,17 +19,17 @@
exports.config = {
directConnect: false,
capabilities: {
- 'browserName': 'phantomjs',
+ 'browserName': 'chrome',
--- End diff --
Bad: restore `phantomjs` here!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/47#discussion_r124199801
--- Diff: client/enduser/src/main/java/org/apache/syncope/client/enduser/resources/UserSelfReadResource.java ---
@@ -137,12 +137,13 @@ public void writeData(final Attributes attributes) throws IOException {
private void customizeAttrs(final Set<AttrTO> attrs,
final Map<String, CustomAttribute> customForm) {
- CollectionUtils.filter(attrs, new Predicate<AttrTO>() {
-
- @Override
- public boolean evaluate(final AttrTO attr) {
- return customForm.containsKey(attr.getSchema());
+ Set<AttrTO> attrsToAdd = new HashSet<>();
--- End diff --
You could use `CollectionUtils.collect()` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope issue #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]
Posted by andrea-patricelli <gi...@git.apache.org>.
Github user andrea-patricelli commented on the issue:
https://github.com/apache/syncope/pull/47
@mat-ale we have almost finished. Please put a check to call completeUserObject only if cuastomForm is not null and not empty and add user virtual attributes management in completeUserObject.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/syncope/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/47#discussion_r124199671
--- Diff: client/enduser/src/main/java/org/apache/syncope/client/enduser/model/CustomAttribute.java ---
@@ -26,18 +26,18 @@
private static final long serialVersionUID = 4910266842123376686L;
- private Boolean readonly;
+ private boolean readonly;
private List<String> defaultValues = new ArrayList<>();
public CustomAttribute() {
}
- public Boolean getReadonly() {
+ public boolean getReadonly() {
--- End diff --
This should be `isReadonly()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---