You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by jm...@apache.org on 2018/01/05 03:34:25 UTC
[incubator-plc4x] branch master updated (63bba4d -> 02b8f57)
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from 63bba4d clean up switch statements a little
new f9d3fa1 no need for local variable
new 02b8f57 unnneeded import
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/main/java/org/apache/plc4x/edgent/PlcConnectionAdapter.java | 3 +--
.../org/apache/plc4x/java/api/connection/AbstractPlcConnection.java | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
--
To stop receiving notification emails like this one, please contact
['"commits@plc4x.apache.org" <co...@plc4x.apache.org>'].
[incubator-plc4x] 01/02: no need for local variable
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit f9d3fa15fded237f29885605227eb6627334d9ae
Author: Justin Mclean <jm...@apache.org>
AuthorDate: Fri Jan 5 14:33:46 2018 +1100
no need for local variable
---
.../src/main/java/org/apache/plc4x/edgent/PlcConnectionAdapter.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/integrations/apache-edgent/src/main/java/org/apache/plc4x/edgent/PlcConnectionAdapter.java b/integrations/apache-edgent/src/main/java/org/apache/plc4x/edgent/PlcConnectionAdapter.java
index 2bff661..ab1c709 100644
--- a/integrations/apache-edgent/src/main/java/org/apache/plc4x/edgent/PlcConnectionAdapter.java
+++ b/integrations/apache-edgent/src/main/java/org/apache/plc4x/edgent/PlcConnectionAdapter.java
@@ -112,8 +112,7 @@ public class PlcConnectionAdapter implements AutoCloseable{
address = connection.parseAddress(addressStr);
PlcReader reader = connection.getReader().get();
PlcReadRequest readRequest = PlcConnectionAdapter.newPlcReadRequest(datatype, address);
- T value = (T) reader.read(readRequest).get().getResponseItems().get(0).getValues().get(0);
- return value;
+ return (T) reader.read(readRequest).get().getResponseItems().get(0).getValues().get(0);
}
catch (Exception e) {
logger.error("reading from plc device {} {} failed", connection, address, e);
--
To stop receiving notification emails like this one, please contact
"commits@plc4x.apache.org" <co...@plc4x.apache.org>.
[incubator-plc4x] 02/02: unnneeded import
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit 02b8f570efe7ef84665241b20107a1395a6a628c
Author: Justin Mclean <jm...@apache.org>
AuthorDate: Fri Jan 5 14:34:18 2018 +1100
unnneeded import
---
.../org/apache/plc4x/java/api/connection/AbstractPlcConnection.java | 2 --
1 file changed, 2 deletions(-)
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/AbstractPlcConnection.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/AbstractPlcConnection.java
index 6d7a847..0216091 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/AbstractPlcConnection.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/AbstractPlcConnection.java
@@ -18,8 +18,6 @@ under the License.
*/
package org.apache.plc4x.java.api.connection;
-import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
-
import java.util.Optional;
public abstract class AbstractPlcConnection implements PlcConnection {
--
To stop receiving notification emails like this one, please contact
"commits@plc4x.apache.org" <co...@plc4x.apache.org>.