You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Rakesh R <ra...@huawei.com> on 2013/11/06 03:20:13 UTC

Review Request 15256: ZOOKEEPER-442: need a way to remove watches that are no longer of interest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15256/
-----------------------------------------------------------

Review request for zookeeper, fpj and Mahadev Konar.


Bugs: ZOOKEEPER-442
    https://issues.apache.org/jira/browse/ZOOKEEPER-442


Repository: zookeeper


Description
-------

Added APIs to remove watches that are not needed anymore. If the removal completes successfully it is guaranteed that the watcher won't be notified.


Diffs
-----

  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/KeeperException.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/WatchDeregistration.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/Watcher.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WatchManager.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1533155 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/RemoveWatchesTest.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/zookeeper.jute 1533155 

Diff: https://reviews.apache.org/r/15256/diff/


Testing
-------

Added unit test cases to see the client behaviors


Thanks,

Rakesh R


Re: Review Request 15256: ZOOKEEPER-442: need a way to remove watches that are no longer of interest

Posted by Rakesh R <ra...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15256/#review29046
-----------------------------------------------------------


- Rakesh R


On Nov. 6, 2013, 2:20 a.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15256/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 2:20 a.m.)
> 
> 
> Review request for zookeeper, fpj and Mahadev Konar.
> 
> 
> Bugs: ZOOKEEPER-442
>     https://issues.apache.org/jira/browse/ZOOKEEPER-442
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Added APIs to remove watches that are not needed anymore. If the removal completes successfully it is guaranteed that the watcher won't be notified.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/KeeperException.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/WatchDeregistration.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/Watcher.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WatchManager.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1533155 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/RemoveWatchesTest.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/zookeeper.jute 1533155 
> 
> Diff: https://reviews.apache.org/r/15256/diff/
> 
> 
> Testing
> -------
> 
> Added unit test cases to see the client behaviors
> 
> 
> Thanks,
> 
> Rakesh R
> 
>