You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/11/20 08:38:28 UTC
Review Request 40529: WIP: Added helper function to get stateless
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
Review request for mesos and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs
-----
include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b
include/mesos/v1/resources.hpp 92db123507ba3442d475c5d3bb7e1a375cf5c1b2
src/common/resources.cpp f1da3237724b3766a5df1cb0a4c0159fb9098e01
src/tests/resources_tests.cpp 0d084fd97ec108d5ec2d050eddc2e80ea81ffac0
src/v1/resources.cpp 6f50101538cf30ebb5a8022558108f103d62a44c
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: WIP: Added helper function to get stateless
resources.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review107540
-----------------------------------------------------------
src/common/resources.cpp (line 654)
<https://reviews.apache.org/r/40529/#comment166758>
After confirmed in design dock, `stateless` is `!persistentVolume`.
- Klaus Ma
On Nov. 20, 2015, 8:59 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 8:59 p.m.)
>
>
> Review request for mesos and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to get stateless resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b
> include/mesos/v1/resources.hpp 92db123507ba3442d475c5d3bb7e1a375cf5c1b2
> src/common/resources.cpp f1da3237724b3766a5df1cb0a4c0159fb9098e01
> src/tests/resources_tests.cpp 0d084fd97ec108d5ec2d050eddc2e80ea81ffac0
> src/v1/resources.cpp 6f50101538cf30ebb5a8022558108f103d62a44c
>
> Diff: https://reviews.apache.org/r/40529/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 5:56 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211
src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399
src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717
Diff: https://reviews.apache.org/r/40529/diff/
Testing (updated)
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十二月 7, 2015, 2:59 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211
src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399
src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十二月 7, 2015, 2:26 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Changes
-------
Address Joseph's comments
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211
src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399
src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review108874
-----------------------------------------------------------
Looks good. Just a few nits.
include/mesos/resources.hpp (line 156)
<https://reviews.apache.org/r/40529/#comment168337>
You should surround `!isPersistentVolume` in backticks. We use backticks for code inside comments.
Same for all copy-pasted comments.
include/mesos/resources.hpp (line 235)
<https://reviews.apache.org/r/40529/#comment168338>
Note: You have an extra "s" (typo) at the end of `!persistentVolumes`.
src/tests/resources_tests.cpp (lines 1794 - 1798)
<https://reviews.apache.org/r/40529/#comment168339>
Can you remove some of the newlines here?
Also comment that PersistentVolumes are stateful resources.
- Joseph Wu
On Dec. 2, 2015, 8:35 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 8:35 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to get stateless resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
> include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
> src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211
> src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399
> src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717
>
> Diff: https://reviews.apache.org/r/40529/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十二月 3, 2015, 4:35 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d
include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa
src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211
src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399
src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十二月 1, 2015, 2:14 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Changes
-------
Remove depdency
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs
-----
include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review108433
-----------------------------------------------------------
include/mesos/resources.hpp (lines 155 - 156)
<https://reviews.apache.org/r/40529/#comment167893>
Can you add a comment here to explain that this is the same as `!isPersistentVolume`?
i.e. This function is not redundant. There is only one type of stateful resource currently. But if more are added in future, this function should be extended accordingly.
---
Note: You may want to hold back on copy-pasting the comment all over this patch (which we will eventually want). We will likely iterate over the wording a bit first :)
- Joseph Wu
On Nov. 24, 2015, 11:31 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 11:31 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to get stateless resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
> include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
> src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
> src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
> src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
>
> Diff: https://reviews.apache.org/r/40529/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十一月 25, 2015, 7:31 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十一月 25, 2015, 6:41 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十一月 24, 2015, 8:08 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十一月 24, 2015, 5:42 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Summary (updated)
-----------------
Added helper function to get stateless resources.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: WIP: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十一月 20, 2015, 12:59 p.m.)
Review request for mesos and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b
include/mesos/v1/resources.hpp 92db123507ba3442d475c5d3bb7e1a375cf5c1b2
src/common/resources.cpp f1da3237724b3766a5df1cb0a4c0159fb9098e01
src/tests/resources_tests.cpp 0d084fd97ec108d5ec2d050eddc2e80ea81ffac0
src/v1/resources.cpp 6f50101538cf30ebb5a8022558108f103d62a44c
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40529: WIP: Added helper function to get stateless
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
-----------------------------------------------------------
(Updated 十一月 20, 2015, 11:51 a.m.)
Review request for mesos and Klaus Ma.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Added helper function to get stateless resources.
Diffs (updated)
-----
include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b
include/mesos/v1/resources.hpp 92db123507ba3442d475c5d3bb7e1a375cf5c1b2
src/common/resources.cpp f1da3237724b3766a5df1cb0a4c0159fb9098e01
src/tests/resources_tests.cpp 0d084fd97ec108d5ec2d050eddc2e80ea81ffac0
src/v1/resources.cpp 6f50101538cf30ebb5a8022558108f103d62a44c
Diff: https://reviews.apache.org/r/40529/diff/
Testing
-------
Thanks,
Guangya Liu