[jira] [Commented] (YARN-3081) Potential indefinite wait in ContainerManagementProtocolProxy#addProxyToCache()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286659#comment-14286659 ] 

Hadoop QA commented on YARN-3081:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12693750/yarn-3081-001.patch
  against trunk revision 0742591.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6381//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6381//console

This message is automatically generated.

> Potential indefinite wait in ContainerManagementProtocolProxy#addProxyToCache()
> -------------------------------------------------------------------------------
>
>                 Key: YARN-3081
>                 URL: https://issues.apache.org/jira/browse/YARN-3081
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: yarn-3081-001.patch
>
>
> {code}
>       if (!removedProxy) {
>         // all of the proxies are currently in use and already scheduled
>         // for removal, so we need to wait until at least one of them closes
>         try {
>           this.wait();
> {code}
> The above code can wait for a condition that has already been satisfied, leading to indefinite wait.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)