You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org> on 2011/12/12 18:17:31 UTC

[jira] [Commented] (SLING-2289) Implement generic retry mechanism

    [ https://issues.apache.org/jira/browse/SLING-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167601#comment-13167601 ] 

Carsten Ziegeler commented on SLING-2289:
-----------------------------------------

In fact, the handling of retries was a little bit confusing and different between tasks. Some tasks simply assumed that they get re-invoked correctly while others implemented retry counters etc.
I've now cleaned up the api and task handling: if a task does nothing it is retried and it's up the installer to detect when something should be retried. As the installer needs input from the outside I'Ve added a new RetryHandler interface which should be invoked by listeners whenever they think that a retry makes sense. For example if a bundle got installed etc.
                
> Implement generic retry mechanism
> ---------------------------------
>
>                 Key: SLING-2289
>                 URL: https://issues.apache.org/jira/browse/SLING-2289
>             Project: Sling
>          Issue Type: New Feature
>          Components: Installer
>    Affects Versions: Installer Core 3.2.2
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Installer Core 3.2.4
>
>
> Currently, if a task fails it is retried over and over again which basically is kind of an endless loop.
> However, if between two retries nothing has changed, it is most likely that a retry is failing again. We have some basic code for bundle handling, but this is a) tied to bundles, b) not reusable, and c) not working perfectly.
> Instead we should come up with a generic mechanism for retries - a task should signal that it want's to be retried. In addition we need a notification mechanism which notifies the installer to retry something, e.g. a service listening for bundle events would notify the installer each time a bundle event has occurred etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira