You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by CodingFabian <gi...@git.apache.org> on 2015/03/23 10:43:08 UTC

[GitHub] commons-lang pull request: Some minor fixup of LANG-935.

GitHub user CodingFabian opened a pull request:

    https://github.com/apache/commons-lang/pull/56

    Some minor fixup of LANG-935.

    Avoid toString() of the replacement sequence by doing it once.
    Avoid calculating the maximum when not needed.
    Fixup comment for greedy algorithm.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/commons-lang LANG-935-additions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit b8a7b292e52b88ee6fc88159dcfd7860920b8ad0
Author: Fabian Lange <la...@gmail.com>
Date:   2015-03-23T09:37:09Z

    Some minor fixup of LANG-935.
    
    Avoid toString() of the replacement sequence by doing it once.
    Avoid calculating the maximum when not needed.
    Fixup comment for greedy algorithm.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-lang pull request: Some minor fixup of LANG-935.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org