[GitHub] [incubator-tamaya] acoburn opened a new pull request #44: TAMAYA-277 adjust sonar configuration

[GitBox <gi...@apache.org>]

acoburn opened a new pull request #44: TAMAYA-277 adjust sonar configuration
URL: https://github.com/apache/incubator-tamaya/pull/44
 
 
   It's hard to actually test this, but there are a few adjustments here that should help. 
   
   First, JaCoCo wasn't actually turned on for the `tamaya-core` module (overriding the `argLine` had removed JaCoCo's own override). 
   Second, JaCoCo had to be manually invoked, by moving the configuration from `<pluginManagement>` to `<plugins>`, it is now tied to the `mvn verify` stage.
   Next, it seems that the `SONAR_TOKEN` can be interpolated as shown in the adjustment to `.travis.yml`, and perhaps that is required
   Finally, I added a number of sonar-specific properties directly to the `pom.xml` file.
   
   @ottlinger has the SonarCloud token, so you might be able to test this locally. Or, you can just merge it and see how it works. My experience with SonarCloud integration involves gradle, so I don't have a working Maven config to share, but hopefully this will get us closer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services