[GitHub] [hive] jcamachor commented on a change in pull request #1302: HIVE-23908: Rewrite plan to join back tables: handle root input is an Aggregate

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #1302:
URL: https://github.com/apache/hive/pull/1302#discussion_r460341568



##########
File path: ql/src/test/results/clientpositive/llap/constraints_optimization.q.out
##########
@@ -2689,13 +2689,17 @@ POSTHOOK: Input: default@store_sales
 #### A masked pattern was here ####
 CBO PLAN:
 HiveProject(c_customer_id=[$1])
-  HiveAggregate(group=[{0, 1}])
-    HiveJoin(condition=[=($0, $8)], joinType=[inner], algorithm=[none], cost=[not available])
-      HiveProject(c_customer_sk=[$0], c_customer_id=[$1], c_first_name=[$8], c_last_name=[$9], c_preferred_cust_flag=[$10], c_birth_country=[$14], c_login=[$15], c_email_address=[$16])
-        HiveTableScan(table=[[default, customer]], table:alias=[customer])
-      HiveProject(ss_customer_sk=[$3])
-        HiveFilter(condition=[IS NOT NULL($3)])
-          HiveTableScan(table=[[default, store_sales]], table:alias=[store_sales])
+  HiveSemiJoin(condition=[=($0, $2)], joinType=[semi])

Review comment:
       We should not trigger the optimization in this case, since it is just doing consecutively the same join. However, this is not actually related to this patch. Can we create a follow-up?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org