You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2022/06/08 19:33:18 UTC

[trafficserver] branch 9.2.x updated: Removed references to the throttle option from the slice plugin. (#8373) (#8897)

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 9.2.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/9.2.x by this push:
     new a7f36998d Removed references to the throttle option from the slice plugin. (#8373) (#8897)
a7f36998d is described below

commit a7f36998d3fa84e837cd0fd82bb851072eadd59c
Author: Jeff Elsloo <el...@users.noreply.github.com>
AuthorDate: Wed Jun 8 13:33:03 2022 -0600

    Removed references to the throttle option from the slice plugin. (#8373) (#8897)
    
    (cherry picked from commit e7b69489716a2c4460b482c59bf013e241c44e9b)
---
 doc/admin-guide/plugins/slice.en.rst | 11 -----------
 plugins/experimental/slice/Config.cc |  2 +-
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/doc/admin-guide/plugins/slice.en.rst b/doc/admin-guide/plugins/slice.en.rst
index b16f338e7..7f5bc850e 100644
--- a/doc/admin-guide/plugins/slice.en.rst
+++ b/doc/admin-guide/plugins/slice.en.rst
@@ -113,17 +113,6 @@ The slice plugin supports the following options::
         Requires setting up an intermediate loopback remap rule.
         -r for short
 
-    --throttle (optional)
-        Under certain circumstances where many contiguous slices are in
-        RAM cache ATS will aggressively try to push these through the
-        slice plugin.  The downside of this is that all these contiguous
-        slices end up being marked as fresh even if the downstream
-        client aborts.  This option keeps track of how much data the
-        client has already passed down and slows down issuing new
-        slice requests.
-        Normally leave this off.
-        -o for short
-
     --prefetch-count=<int> (optional)
         Default is 0
         Prefetches successive 'n' slice block requests in the background
diff --git a/plugins/experimental/slice/Config.cc b/plugins/experimental/slice/Config.cc
index 5d9b66f07..964dad362 100644
--- a/plugins/experimental/slice/Config.cc
+++ b/plugins/experimental/slice/Config.cc
@@ -122,7 +122,7 @@ Config::fromArgs(int const argc, char const *const argv[])
   // getopt assumes args start at '1' so this hack is needed
   char *const *argvp = (const_cast<char *const *>(argv) - 1);
   for (;;) {
-    int const opt = getopt_long(argc + 1, argvp, "b:de:i:lop:r:t:", longopts, nullptr);
+    int const opt = getopt_long(argc + 1, argvp, "b:de:i:lp:r:t:", longopts, nullptr);
     if (-1 == opt) {
       break;
     }