You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/08/04 11:39:55 UTC
Review Request 37070: LENS-712 : Seeing Exception while initializing
PathScanner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94029
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (lines 152 - 155)
<https://reviews.apache.org/r/37070/#comment148532>
These can be merged.
- Rajat Khandelwal
On Aug. 4, 2015, 3:14 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:14 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
> [INFO] Lens ............................................... SUCCESS [ 3.075 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.232 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
> [INFO] Lens Server ........................................ SUCCESS [05:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.087 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
> [INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52 min
> [INFO] Finished at: 2015-08-04T15:06:08+05:30
> [INFO] Final Memory: 132M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94065
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 101)
<https://reviews.apache.org/r/37070/#comment148567>
Can we add a **null** check here as well?
- Raju Bairishetti
On Aug. 4, 2015, 3:13 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:13 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
> [INFO] Lens ............................................... SUCCESS [ 3.075 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.232 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
> [INFO] Lens Server ........................................ SUCCESS [05:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.087 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
> [INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52 min
> [INFO] Finished at: 2015-08-04T15:06:08+05:30
> [INFO] Final Memory: 132M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 7 a.m.)
Review request for lens.
Changes
-------
New review ccomments.
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
[INFO] Lens ............................................... SUCCESS [ 3.433 s]
[INFO] Lens API ........................................... SUCCESS [ 26.192 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.487 s]
[INFO] Lens Cube .......................................... SUCCESS [05:31 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.218 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.300 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 39.087 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 17.876 s]
[INFO] Lens Server ........................................ SUCCESS [06:49 min]
[INFO] Lens client ........................................ SUCCESS [ 40.727 s]
[INFO] Lens CLI ........................................... SUCCESS [02:20 min]
[INFO] Lens Examples ...................................... SUCCESS [ 12.139 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.580 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:36 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.964 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.538 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:50 min
[INFO] Finished at: 2015-08-05T12:22:14+05:30
[INFO] Final Memory: 133M/397M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94178
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On Aug. 4, 2015, 4:37 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 4:37 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.912 s]
> [INFO] Lens ............................................... SUCCESS [ 2.869 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.009 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.469 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:23 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.484 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.607 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.065 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.646 s]
> [INFO] Lens Server ........................................ SUCCESS [05:01 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.274 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.084 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.434 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:12 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.170 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.219 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:33 min
> [INFO] Finished at: 2015-08-04T21:44:13+05:30
> [INFO] Final Memory: 132M/425M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94180
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 152)
<https://reviews.apache.org/r/37070/#comment148723>
Exception need not be parameterized.
- Amareshwari Sriramadasu
On Aug. 4, 2015, 4:37 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 4:37 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.912 s]
> [INFO] Lens ............................................... SUCCESS [ 2.869 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.009 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.469 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:23 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.484 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.607 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.065 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.646 s]
> [INFO] Lens Server ........................................ SUCCESS [05:01 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.274 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.084 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.434 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:12 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.170 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.219 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:33 min
> [INFO] Finished at: 2015-08-04T21:44:13+05:30
> [INFO] Final Memory: 132M/425M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 4:37 p.m.)
Review request for lens.
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.912 s]
[INFO] Lens ............................................... SUCCESS [ 2.869 s]
[INFO] Lens API ........................................... SUCCESS [ 22.009 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.469 s]
[INFO] Lens Cube .......................................... SUCCESS [05:23 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.484 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.607 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.065 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.646 s]
[INFO] Lens Server ........................................ SUCCESS [05:01 min]
[INFO] Lens client ........................................ SUCCESS [ 36.274 s]
[INFO] Lens CLI ........................................... SUCCESS [02:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.084 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.434 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:12 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.170 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.219 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:33 min
[INFO] Finished at: 2015-08-04T21:44:13+05:30
[INFO] Final Memory: 132M/425M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94074
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 157)
<https://reviews.apache.org/r/37070/#comment148576>
Please do not close FileSystem. Closing filesystem will lead to other consequences as filesystems instances are cached onces. Refer https://issues.apache.org/jira/browse/HADOOP-7973
- Raju Bairishetti
On Aug. 4, 2015, 4:17 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 4:17 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.912 s]
> [INFO] Lens ............................................... SUCCESS [ 2.869 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.009 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.469 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:23 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.484 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.607 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.065 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.646 s]
> [INFO] Lens Server ........................................ SUCCESS [05:01 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.274 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.084 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.434 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:12 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.170 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.219 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:33 min
> [INFO] Finished at: 2015-08-04T21:44:13+05:30
> [INFO] Final Memory: 132M/425M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 4:17 p.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.912 s]
[INFO] Lens ............................................... SUCCESS [ 2.869 s]
[INFO] Lens API ........................................... SUCCESS [ 22.009 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.469 s]
[INFO] Lens Cube .......................................... SUCCESS [05:23 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.484 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.607 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.065 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.646 s]
[INFO] Lens Server ........................................ SUCCESS [05:01 min]
[INFO] Lens client ........................................ SUCCESS [ 36.274 s]
[INFO] Lens CLI ........................................... SUCCESS [02:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.084 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.434 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:12 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.170 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.219 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:33 min
[INFO] Finished at: 2015-08-04T21:44:13+05:30
[INFO] Final Memory: 132M/425M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94069
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 114)
<https://reviews.apache.org/r/37070/#comment148570>
Can we take care of closing the input stream?
- Raju Bairishetti
On Aug. 4, 2015, 3:13 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:13 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
> [INFO] Lens ............................................... SUCCESS [ 3.075 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.232 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
> [INFO] Lens Server ........................................ SUCCESS [05:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.087 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
> [INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52 min
> [INFO] Finished at: 2015-08-04T15:06:08+05:30
> [INFO] Final Memory: 132M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 3:13 p.m.)
Review request for lens.
Changes
-------
Review comments - Log format bugfix.
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
[INFO] Lens ............................................... SUCCESS [ 3.075 s]
[INFO] Lens API ........................................... SUCCESS [ 22.232 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
[INFO] Lens Cube .......................................... SUCCESS [06:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
[INFO] Lens Server ........................................ SUCCESS [05:58 min]
[INFO] Lens client ........................................ SUCCESS [ 38.087 s]
[INFO] Lens CLI ........................................... SUCCESS [02:11 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
[INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
[INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52 min
[INFO] Finished at: 2015-08-04T15:06:08+05:30
[INFO] Final Memory: 132M/395M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 4, 2015, 3:01 p.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 151
> > <https://reviews.apache.org/r/37070/diff/1/?file=1028497#file1028497line151>
> >
> > Will this log be printed properly? Can we rewrite log with substitutions?
> >
> > log.error("File not found while scanning path: {} for type: {}", path, type, fex)
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94062
-----------------------------------------------------------
On Aug. 4, 2015, 3:13 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:13 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
> [INFO] Lens ............................................... SUCCESS [ 3.075 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.232 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
> [INFO] Lens Server ........................................ SUCCESS [05:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.087 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
> [INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52 min
> [INFO] Finished at: 2015-08-04T15:06:08+05:30
> [INFO] Final Memory: 132M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/#review94062
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 151)
<https://reviews.apache.org/r/37070/#comment148564>
Will this log be printed properly? Can we rewrite log with substitutions?
log.error("File not found while scanning path: {} for type: {}", path, type, fex)
- Raju Bairishetti
On Aug. 4, 2015, 2:32 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37070/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:32 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Seeing Exception while initializing PathScanner
>
> https://issues.apache.org/jira/browse/LENS-712
>
> Handling for Null Scanned paths + Improved error logging.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
>
> Diff: https://reviews.apache.org/r/37070/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
> [INFO] Lens ............................................... SUCCESS [ 3.075 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.232 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
> [INFO] Lens Server ........................................ SUCCESS [05:58 min]
> [INFO] Lens client ........................................ SUCCESS [ 38.087 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
> [INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:52 min
> [INFO] Finished at: 2015-08-04T15:06:08+05:30
> [INFO] Final Memory: 132M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 2:32 p.m.)
Review request for lens.
Changes
-------
Implemented new review comments
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
[INFO] Lens ............................................... SUCCESS [ 3.075 s]
[INFO] Lens API ........................................... SUCCESS [ 22.232 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
[INFO] Lens Cube .......................................... SUCCESS [06:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
[INFO] Lens Server ........................................ SUCCESS [05:58 min]
[INFO] Lens client ........................................ SUCCESS [ 38.087 s]
[INFO] Lens CLI ........................................... SUCCESS [02:11 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
[INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
[INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52 min
[INFO] Finished at: 2015-08-04T15:06:08+05:30
[INFO] Final Memory: 132M/395M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 37070: LENS-712 : Seeing Exception while
initializing PathScanner
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37070/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 9:44 a.m.)
Review request for lens.
Changes
-------
Adding build results.
Repository: lens
Description
-------
Seeing Exception while initializing PathScanner
https://issues.apache.org/jira/browse/LENS-712
Handling for Null Scanned paths + Improved error logging.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
Diff: https://reviews.apache.org/r/37070/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.984 s]
[INFO] Lens ............................................... SUCCESS [ 3.075 s]
[INFO] Lens API ........................................... SUCCESS [ 22.232 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 19.661 s]
[INFO] Lens Cube .......................................... SUCCESS [06:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.010 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.706 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.805 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.992 s]
[INFO] Lens Server ........................................ SUCCESS [05:58 min]
[INFO] Lens client ........................................ SUCCESS [ 38.087 s]
[INFO] Lens CLI ........................................... SUCCESS [02:11 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.360 s]
[INFO] Lens Distribution .................................. SUCCESS [ 10.107 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:33 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.133 s]
[INFO] Lens Regression .................................... SUCCESS [ 10.887 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:52 min
[INFO] Finished at: 2015-08-04T15:06:08+05:30
[INFO] Final Memory: 132M/395M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma