You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Walter Vaughan (JIRA)" <ji...@apache.org> on 2007/01/22 20:23:29 UTC
[jira] Created: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Pagination in https://host_name:8443/ordermgr/control/orderlist needed
----------------------------------------------------------------------
Key: OFBIZ-644
URL: https://issues.apache.org/jira/browse/OFBIZ-644
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: order
Affects Versions: SVN trunk
Environment: All
Reporter: Walter Vaughan
Fix For: SVN trunk
There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467488 ]
Jacques Le Roux commented on OFBIZ-644:
---------------------------------------
Quick answer : try a merge
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-644.
---------------------------------
Resolution: Fixed
The problem reported by Rohit is fixed in rev. 507490
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470440 ]
Jacques Le Roux commented on OFBIZ-644:
---------------------------------------
Chris,
>Is this a request that contributors not overlook their option here or a suggestion that new file contributions must have the license header in order for committers to consider the file for inclusion?
As David added himself the header I guess it's quite clear that it's "a request that contributors not overlook their option"
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Rohit Sureka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472071 ]
Rohit Sureka commented on OFBIZ-644:
------------------------------------
Hi,
i think there is a bug in the file. The filters do not work properly. For eg. if you select any order status 'Created', 'Approved' etc, all orders with any order status are listed.
Rohit
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467194 ]
Leon Torres commented on OFBIZ-644:
-----------------------------------
Also, I wanted to note that this patch contains an exploraiton on how to handle similar complex lists that require pagination. There is a Java classs in it that is stored in the session, which is responsible for tracking the state of the list. The idea is to use this object instead of passing around dozens of url parameters. If it works well, we can generalize the approach and use it as a design pattern for similar lists.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-644) Pagination in https://host_name:8443/ordermgr/control/orderlist needed
Posted by Chris Howe <cj...@yahoo.com>.
Hi Chris Liberty,
Back in December Hans Bakker posted a link regarding Terracotta
http://www.terracotta.org/ that might eliminate the need for
serialization in a clustered environment. I am not a "Java coder", so
a lot of the information and video lectures on the site were over my
head. Would Terracotta's be a better pattern to pursue or would it be
better to focus on the traditional patterns? Is Terracotta something
that OFBiz in general could benefit from or would it be something that
is difficult to accomplish?
-Chris Howe
--- "Chris Liberty (JIRA)" <ji...@apache.org> wrote:
>
> [
>
https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468703
> ]
>
> Chris Liberty commented on OFBIZ-644:
> -------------------------------------
>
> Nicely done, Leon! Nice to see something that reminds us that we're
> Java coders and not FTL monkeys. Also good to enforce the separation
> of concerns whenever possible.
>
> This would be a very useful object to have in the session at all
> times, if it were generic enough to be used with any paginated list.
>
> A couple of small wishes:
>
> - It would be great if the class implemented Serializable in case the
> session is being replicated across an appserver cluster or needs to
> be persisted.
> - If you do make this generic, a combined getInstance() and update()
> method which would return an object reflecting the current state of
> the list from the request might be useful. It only saves a line, but
> would make it even easier to use.
>
>
> > Pagination in https://host_name:8443/ordermgr/control/orderlist
> needed
> >
>
----------------------------------------------------------------------
> >
> > Key: OFBIZ-644
> > URL:
> https://issues.apache.org/jira/browse/OFBIZ-644
> > Project: OFBiz (The Open for Business Project)
> > Issue Type: Improvement
> > Components: order
> > Affects Versions: SVN trunk
> > Environment: All
> > Reporter: Walter Vaughan
> > Assigned To: Jacques Le Roux
> > Fix For: SVN trunk
> >
> > Attachments: orderliststate-svn.patch, orderliststate.patch
> >
> >
> > There is no pagination in
> https://host_name:8443/ordermgr/control/orderlist. If a status like
> "sent' is chosen, thousands or millions of rows will be returned if
> there is that many in the database. Some sort of pagination system
> like we have in https://host_name:8443/partymgr/control/findparty
> with some sort of higher limit like 100 records or so might be good,
> as to not break behavior for most existing users.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Chris Liberty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468703 ]
Chris Liberty commented on OFBIZ-644:
-------------------------------------
Nicely done, Leon! Nice to see something that reminds us that we're Java coders and not FTL monkeys. Also good to enforce the separation of concerns whenever possible.
This would be a very useful object to have in the session at all times, if it were generic enough to be used with any paginated list.
A couple of small wishes:
- It would be great if the class implemented Serializable in case the session is being replicated across an appserver cluster or needs to be persisted.
- If you do make this generic, a combined getInstance() and update() method which would return an object reflecting the current state of the list from the request might be useful. It only saves a line, but would make it even easier to use.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470149 ]
Jacques Le Roux commented on OFBIZ-644:
---------------------------------------
David,
Sorry for the header. I added the properties file but was not sure about that. I agree that there are already enough parameters in OFBiz.
Before commiting this patch, I wondered (not for the 1st time) why there was not already a standard pagination in the order list page. Are there any reasons ?
But after all, the solution was there, worked well and seemed interesting enough to be commited. So I dropped it in waiting for reactions. Do you tnink we should revert it and use standard pagination ?
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-644:
-------------------------------------
Assignee: Jacques Le Roux
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leon Torres updated OFBIZ-644:
------------------------------
Attachment: orderliststate.patch
I created a paginated version of the page awhile back, against r 463793. It's not a trivial thing to do because it is an ftl file and has a lot of state to keep track of.
Please try this out and let us know if it works or not. :-)
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470101 ]
David E. Jones commented on OFBIZ-644:
--------------------------------------
Another VERY IMPORTANT NOTE: this new file added in this patch did NOT have a license header, so the patch should have been rejected for that.
I think the history and intent are clear enough for this, so I'll just add a header.
In the future, for those submitting patches with new files: please add a license header.
In the future, for reviewing submitted patches with new files: please make sure there is a license header for each file.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469880 ]
Jacques Le Roux commented on OFBIZ-644:
---------------------------------------
Leon, Chris,
I just tested it. Nice indeed, just a problem with filters that are re-intitialised between each page. I will take care of that. This patch is something I agree we really need. I added filters some months ago and changed the way that was done recently because of pagination problem in Find Order page (same filters reused there).
Thanks
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467485 ]
Leon Torres commented on OFBIZ-644:
-----------------------------------
Yeah sorry, this patch was against r 463793. I'm short on time to update it for the changes to orderlist, but it should be relatively straightforward to fix. I'm just putting this on the table in case Jacques or anyone wants to take a crack at it now.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470100 ]
David E. Jones commented on OFBIZ-644:
--------------------------------------
In general I don't like the pattern used in this patch. It doesn't follow best practices or use the tools and patterns established in OFBiz to make all of our lives easier, during implementation but even more importantly during maintenance and customization. There are very good reasons we recommend using object oriented patterns written in Java on only very rare occasions. This is a good example of something that is not complex enough to justify, and it will be a maintenance problem in the future.
There is one place where it crosses a line that I'm really not okay with. If we added properties files for every little thing like this we would have hundreds of them lying around, a nightmare to navigate, use, and maintain. So, that is going away in a few minutes.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467201 ]
Jacques Le Roux commented on OFBIZ-644:
---------------------------------------
Yes this is an interesting point, I will also take care of that ASAP
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "David Shere (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467454 ]
David Shere commented on OFBIZ-644:
-----------------------------------
Applying patch orderliststate.patch, I get this:
root@raptor:/ofbiz# patch -p 0 < tmp/orderliststate.patch
patching file applications/order/src/org/ofbiz/order/order/OrderListState.java
patching file applications/order/entitydef/entitymodel_view.xml
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file applications/order/entitydef/entitymodel_view.xml.rej
patching file applications/order/webapp/ordermgr/WEB-INF/actions/order/orderlist.bsh
Hunk #1 succeeded at 21 (offset 2 lines).
Hunk #2 FAILED at 31.
1 out of 2 hunks FAILED -- saving rejects to file applications/order/webapp/ordermgr/WEB-INF/actions/order/orderlist.bsh.rej
patching file applications/order/webapp/ordermgr/order/orderlist.ftl
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 88.
Hunk #3 succeeded at 268 (offset 58 lines).
2 out of 3 hunks FAILED -- saving rejects to file applications/order/webapp/ordermgr/order/orderlist.ftl.rej
root@raptor:/ofbiz#
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-644.
---------------------------------
Resolution: Fixed
Leon,
Your patch is in OFBiz rev . 503391
I added filters.
I kept how one-line getters and setters are formatted. Not sure it would be better to put them on more lines.
I deleted the "TODO: Bug: Clicking All so none are selected shows all orders anyway". Because I think this is a good behaviour (re-checking some options by default). Who would want to search for an empty list ? BTW it"s the default checked options.
As you suggested adding links to specific pages in macro @pagination could be a good idea.
I wonder now if we will use this new pagination in other places...
Thanks
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470279 ]
Chris Howe commented on OFBIZ-644:
----------------------------------
>In the future, for those submitting patches with new files: please add a license header.
Is this a request that contributors not overlook their option here or a suggestion that new file contributions must have the license header in order for committers to consider the file for inclusion?
To be clear, there is an additional instruction in the license header that many noncommitters may not be concerned about and may not wish to imply with work they own the copyright to:
"you may not use this file except in compliance with the License"
The ASF may wish to bind all people with whom they distribute the file to as a part of the collective work that is "Apache OFBiz" with this restriction. That is the ASF's business and their policy regarding committers can certainly reflect that.
By the contributor granting to the ASF license to modify, etc as per the Apache Software License, committers are well within their right to modify the header in any manner they wish that is consistent with that license.
Including the header may make less work for committers, but contributors need not imply additional restrictions unless that is indeed their wish with their original work in order to share with the community.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reopened OFBIZ-644:
-----------------------------------
I will take care of that.
Thanks Rohit for feedback.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470148 ]
Jacques Le Roux commented on OFBIZ-644:
---------------------------------------
David,
Sorry for the header. I added the
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-644) Pagination in
https://host_name:8443/ordermgr/control/orderlist needed
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leon Torres updated OFBIZ-644:
------------------------------
Attachment: orderliststate-svn.patch
Hi, I just updated my code and now it works against ofbiz SVN.
It actually works pretty well, the only thing left to do is polish it by adding the ability to configure the view size in a config property, maybe change the <@paginate> macro to make it more user friendly (insert links to specific pages if the list is large, such as on forums), and add an indicator for what page it is at.
There's some debugging code in there to help track the state of the form. Also, I guess those extra checkbox fields will have to be added in at some point.
> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
> Key: OFBIZ-644
> URL: https://issues.apache.org/jira/browse/OFBIZ-644
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. If a status like "sent' is chosen, thousands or millions of rows will be returned if there is that many in the database. Some sort of pagination system like we have in https://host_name:8443/partymgr/control/findparty with some sort of higher limit like 100 records or so might be good, as to not break behavior for most existing users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.