Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

[Garrett Rooney <ro...@electricjellyfish.net>]

On 7/14/06, C. Michael Pilato <cm...@collab.net> wrote:
> I just noticed (as part of a conversation with Philipp Marek re: Issue 1954)
> that in r12632, Karl added code to svn_fs_make_file(), _make_dir(), and
> _copy() to call svn_path_check_valid() before creating new paths in the
> repository.
>
> Um.  Why?
>
> We have a repository layer for adding such superficial sanity checks.
> There's nothing that I can think of that would cause filenames with control
> characters to be a problem in libsvn_fs, unless the FSFS backend can't hack
> it.  Is that the case?  If so, should we not have a) put the protection in
> the repos layer, and b) also put it in the FSFS backend only?  Why is the
> BDB backend unnecessarily crippled like so?

FSFS shouldn't have any problem with such paths AFAIK.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

[Daniel Rall <dl...@collab.net>]

On Fri, 14 Jul 2006, Garrett Rooney wrote:

> On 7/14/06, Daniel Rall <dl...@collab.net> wrote:
> >On Fri, 14 Jul 2006, C. Michael Pilato wrote:
> >
> >> Greg Hudson wrote:
> >> > On Fri, 2006-07-14 at 12:28 -0400, Garrett Rooney wrote:
> >> >
> >> >>FSFS shouldn't have any problem with such paths AFAIK.
> >> >
> >> >
> >> > FSFS will have trouble with newlines in pathnames... but then again, so
> >> > will our dumpfile format.
> >>
> >> Ah... the dumpfile format.  That's an interesting one...
> >
> >Shouldn't problem characters be escaped when dumping loading, rather
> >than when saving to the FS?
> 
> Back in the day when this discussion occurred it was just decided that
> nobody should have newlines in filenames, since it's evil, and it
> simplifies the dumpfile format (which was a design goal for it, IIRC).

Sure.  But these are users that we're talking about...

Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

["C. Michael Pilato" <cm...@collab.net>]

Garrett Rooney wrote:
> On 7/14/06, Daniel Rall <dl...@collab.net> wrote:
> 
>> On Fri, 14 Jul 2006, C. Michael Pilato wrote:
>>
>> > Greg Hudson wrote:
>> > > On Fri, 2006-07-14 at 12:28 -0400, Garrett Rooney wrote:
>> > >
>> > >>FSFS shouldn't have any problem with such paths AFAIK.
>> > >
>> > >
>> > > FSFS will have trouble with newlines in pathnames... but then
>> again, so
>> > > will our dumpfile format.
>> >
>> > Ah... the dumpfile format.  That's an interesting one...
>>
>> Shouldn't problem characters be escaped when dumping loading, rather
>> than when saving to the FS?
> 
> 
> Back in the day when this discussion occurred it was just decided that
> nobody should have newlines in filenames, since it's evil, and it
> simplifies the dumpfile format (which was a design goal for it, IIRC).

Makes sense to me.  But that still leaves allllllll the other unnecessary
control character blockage down at the filesystem level.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

[Garrett Rooney <ro...@electricjellyfish.net>]

On 7/14/06, Daniel Rall <dl...@collab.net> wrote:
> On Fri, 14 Jul 2006, C. Michael Pilato wrote:
>
> > Greg Hudson wrote:
> > > On Fri, 2006-07-14 at 12:28 -0400, Garrett Rooney wrote:
> > >
> > >>FSFS shouldn't have any problem with such paths AFAIK.
> > >
> > >
> > > FSFS will have trouble with newlines in pathnames... but then again, so
> > > will our dumpfile format.
> >
> > Ah... the dumpfile format.  That's an interesting one...
>
> Shouldn't problem characters be escaped when dumping loading, rather
> than when saving to the FS?

Back in the day when this discussion occurred it was just decided that
nobody should have newlines in filenames, since it's evil, and it
simplifies the dumpfile format (which was a design goal for it, IIRC).

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

[Daniel Rall <dl...@collab.net>]

On Fri, 14 Jul 2006, C. Michael Pilato wrote:

> Greg Hudson wrote:
> > On Fri, 2006-07-14 at 12:28 -0400, Garrett Rooney wrote:
> > 
> >>FSFS shouldn't have any problem with such paths AFAIK.
> > 
> > 
> > FSFS will have trouble with newlines in pathnames... but then again, so
> > will our dumpfile format.
> 
> Ah... the dumpfile format.  That's an interesting one...

Shouldn't problem characters be escaped when dumping loading, rather
than when saving to the FS?

Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

["C. Michael Pilato" <cm...@collab.net>]

Greg Hudson wrote:
> On Fri, 2006-07-14 at 12:28 -0400, Garrett Rooney wrote:
> 
>>FSFS shouldn't have any problem with such paths AFAIK.
> 
> 
> FSFS will have trouble with newlines in pathnames... but then again, so
> will our dumpfile format.

Ah... the dumpfile format.  That's an interesting one...

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Re: Unnecessary crippling of libsvn_fs_base. (Please stop it.)

[Greg Hudson <gh...@MIT.EDU>]

On Fri, 2006-07-14 at 12:28 -0400, Garrett Rooney wrote:
> FSFS shouldn't have any problem with such paths AFAIK.

FSFS will have trouble with newlines in pathnames... but then again, so
will our dumpfile format.

Neither back-end should have trouble with other control characters as
far as I know.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org