[jira] Commented: (SLING-1210) BootstrapInstaller will attempt (and fail) to start fragment bundles

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783787#action_12783787 ] 

Felix Meschberger commented on SLING-1210:
------------------------------------------

Is this a real problem ? IIRC this is just a null-op ?

Your patch is basically fine, except for the isFragment check, which we might want to base on the PackageAdmin.getBundleType(Bundle) method.

> BootstrapInstaller will attempt (and fail) to start fragment bundles
> --------------------------------------------------------------------
>
>                 Key: SLING-1210
>                 URL: https://issues.apache.org/jira/browse/SLING-1210
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>    Affects Versions: Launchpad Base 2.1.0
>            Reporter: Justin Edelson
>
> If you put a fragment bundle in the resource path scanned by BootstrapInstaller, it will attempt to start it, which fails because fragment bundles can't be started.
> I'll provide this as a proper patch soon. Here's an outline of the change:
> new method: 
>     private static boolean isFragment(Bundle bundle) {
>         Dictionary headerMap = bundle.getHeaders();
>         return headerMap.get(Constants.FRAGMENT_HOST) != null;
>     }
> wrap bundle.start() with;
> if (!isFragment(bundle)) {
>                 bundle.start();
>             }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.