You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/10/05 08:54:35 UTC
[GitHub] [qpid-broker-j] Dedeepya-T opened a new pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Dedeepya-T opened a new pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63
Improve operational logging for operations on queue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500180361
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500180619
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
+ {
+ String status = "FAILED";
+ try
+ {
+ _virtualHost.executeTransaction(transaction);
+ status = "SUCCESS";
+ }
+ finally
+ {
+ logOperation(String.format(msg+"Messages :source-%s:target-%s:messagecount-%d:status-%s",
+ getName(),
+ destination.getName(),
+ transaction.getModifiedMessageIds().size(),
+ status));
+ }
+ }
+
@Override
public List<Long> deleteMessages(final List<Long> messageIds, final String selector, int limit)
{
DeleteMessagesTransaction transaction = new DeleteMessagesTransaction(this,
messageIds,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
-
+ String status = "FAILED";
Review comment:
Refactored to use the common method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500748720
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
+ final String destinationName,
+ final QueueManagingVirtualHost.TransactionalOperation transaction)
+ {
+ int messageCount = 0;
+ if (null != transaction)
+ {
+ _virtualHost.executeTransaction(transaction);
+ messageCount = transaction.getModifiedMessageIds().size();
+ }
+ if (null != destinationName)
+ {
+ logOperation(String.format(msg + "Messages : %s: %s: %d",
+ getName(),
+ destinationName,
+ messageCount));
+ }
+ else
+ {
+ logOperation(String.format(msg + " : %s: %d",
+ getName(),
+ messageCount));
+ }
+ }
+
@Override
public List<Long> deleteMessages(final List<Long> messageIds, final String selector, int limit)
{
DeleteMessagesTransaction transaction = new DeleteMessagesTransaction(this,
messageIds,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
-
+ executeTransactionAndLogResults("deleteMessages",null, transaction);
Review comment:
This method is removed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500753048
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
As per another comment this method is removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500180792
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
+ {
+ String status = "FAILED";
Review comment:
Agreed and Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500753180
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
this method no longer exists!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r501474700
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -1826,7 +1826,7 @@ public long clearQueue()
}
txn.commit();
-
+ logOperation(String.format("clearQueue : %s", getName()));
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
alex-rufous commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500679615
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
The parameter name 'msg' needs to be changed to operationName
Let move transaction parameter to a second position
the destinationName can be renamed into a targetdestinationName
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
The entire method implementation can be simplified to something like
`
try
{
_virtualHost.executeTransaction(transaction);
}
finally
{
logOperation(String.format("%s : %s: %s: %d",
operationName,
getName(),
ofNullable(destinationName).orElse(""),
transaction.getModifiedMessageIds().size()));
}
`
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
+ final String destinationName,
+ final QueueManagingVirtualHost.TransactionalOperation transaction)
+ {
+ int messageCount = 0;
+ if (null != transaction)
+ {
+ _virtualHost.executeTransaction(transaction);
+ messageCount = transaction.getModifiedMessageIds().size();
+ }
+ if (null != destinationName)
+ {
+ logOperation(String.format(msg + "Messages : %s: %s: %d",
+ getName(),
+ destinationName,
+ messageCount));
+ }
+ else
+ {
+ logOperation(String.format(msg + " : %s: %d",
+ getName(),
+ messageCount));
+ }
+ }
+
@Override
public List<Long> deleteMessages(final List<Long> messageIds, final String selector, int limit)
{
DeleteMessagesTransaction transaction = new DeleteMessagesTransaction(this,
messageIds,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
-
+ executeTransactionAndLogResults("deleteMessages",null, transaction);
Review comment:
space is missed between parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500743418
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -1826,7 +1827,7 @@ public long clearQueue()
}
txn.commit();
-
+ executeTransactionAndLogResults("clearQueue",null,null);
Review comment:
Applied the simpler fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500193193
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
+ {
+ String status = "FAILED";
+ try
+ {
+ _virtualHost.executeTransaction(transaction);
+ status = "SUCCESS";
+ }
+ finally
+ {
+ logOperation(String.format(msg+"Messages :source-%s:target-%s:messagecount-%d:status-%s",
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
alex-rufous commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500679615
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(), transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
The parameter name 'msg' needs to be changed to operationName
Let's move transaction parameter to a second position
the destinationName can be renamed into a targetDestinationName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
alex-rufous commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500150280
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
+ {
+ String status = "FAILED";
+ try
+ {
+ _virtualHost.executeTransaction(transaction);
+ status = "SUCCESS";
+ }
+ finally
+ {
+ logOperation(String.format(msg+"Messages :source-%s:target-%s:messagecount-%d:status-%s",
Review comment:
I would like to suggest to simplify the operational log messages as below
` logOperation(String.format("%s messages : %s : %s : %d",
operationName,
getName(),
destination.getName(),
transaction.getModifiedMessageIds().size(),
status));`
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
+ {
+ String status = "FAILED";
Review comment:
Let's drop status
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
+ {
+ String status = "FAILED";
+ try
+ {
+ _virtualHost.executeTransaction(transaction);
+ status = "SUCCESS";
+ }
+ finally
+ {
+ logOperation(String.format(msg+"Messages :source-%s:target-%s:messagecount-%d:status-%s",
+ getName(),
+ destination.getName(),
+ transaction.getModifiedMessageIds().size(),
+ status));
+ }
+ }
+
@Override
public List<Long> deleteMessages(final List<Long> messageIds, final String selector, int limit)
{
DeleteMessagesTransaction transaction = new DeleteMessagesTransaction(this,
messageIds,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
-
+ String status = "FAILED";
Review comment:
The code seems duplicate. We should re-use the method introduced above
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3520,52 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ performOperationWithLogging("Copy",destination, transaction);
return transaction.getModifiedMessageIds();
}
+ private void performOperationWithLogging(final String msg,final Queue<?> destination, final QueueSizeLimitRespectingTransaction transaction)
Review comment:
I would like to suggest renaming this method into executeTransactionAndLogResults
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
Dedeepya-T commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r501474700
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -1826,7 +1826,7 @@ public long clearQueue()
}
txn.commit();
-
+ logOperation(String.format("clearQueue : %s", getName()));
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #63: QPID-8472:[Broker-J]Improve operational logging for operations on queue
Posted by GitBox <gi...@apache.org>.
alex-rufous commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500931472
##########
File path: broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -1826,7 +1826,7 @@ public long clearQueue()
}
txn.commit();
-
+ logOperation(String.format("clearQueue : %s", getName()));
Review comment:
Let's add count
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org