You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/06/19 12:45:29 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8574: Skip testcases for LXC i...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/488
CLOUDSTACK-8574: Skip testcases for LXC if storagePool type is not RBD
As LXC DATA disk is supported only on RBD StoragePool so skip testcases for LXC hypervisor if StoragePool type is not RBD
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack lxcRBD
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #488
----
commit 35d7b745193f6f0f7ad9181b01860119222e9a45
Author: pritisarap12 <pr...@clogeny.com>
Date: 2015-06-19T10:41:46Z
CLOUDSTACK-8574: Skip testcases including data disk creation for LXC if storagePool type is not RBD
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8574: Skip testcases for LXC i...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/488#discussion_r33011867
--- Diff: test/integration/component/test_stopped_vm.py ---
@@ -53,6 +54,13 @@ def setUpClass(cls):
cls.domain = get_domain(cls.api_client)
cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ if cls.hypervisor.lower() == 'lxc':
+ if not find_storage_pool_type(cls.apiclient, storagetype='rbd'):
+ raise unittest.SkipTest("RBD storage type is required for data volumes for LXC")
--- End diff --
Done with the review changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8574: Skip testcases for LXC i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8574: Skip testcases for LXC i...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/488#discussion_r32909733
--- Diff: test/integration/component/test_stopped_vm.py ---
@@ -53,6 +54,13 @@ def setUpClass(cls):
cls.domain = get_domain(cls.api_client)
cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ if cls.hypervisor.lower() == 'lxc':
+ if not find_storage_pool_type(cls.apiclient, storagetype='rbd'):
+ raise unittest.SkipTest("RBD storage type is required for data volumes for LXC")
--- End diff --
Don't skip from setUpClass. Skip through individual test case or setUp().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---