You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Klaus Brunner (JIRA)" <ji...@codehaus.org> on 2007/03/15 16:41:34 UTC

[jira] Created: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

RAD goal: missing lib-modules in .websettings
---------------------------------------------

                 Key: MECLIPSE-242
                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
    Affects Versions: 2.3, 2.4
         Environment: IBM Rational Application Developer 6.0.x
            Reporter: Klaus Brunner
         Attachments: RadWebSettingsWriter.java

The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.

Adapted version of RadWebSettingsWriter.java is attached.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_108477 ] 

Brian Fox commented on MECLIPSE-242:
------------------------------------

Applied those. I'm still getting the workspace errors:

{noformat}
-------------------------------------------------------------------------------
Test set: org.apache.maven.plugin.eclipse.EclipseWorkspaceTest
-------------------------------------------------------------------------------
Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 5.47 sec <<< FAILURE!
testWorkspace01(org.apache.maven.plugin.eclipse.EclipseWorkspaceTest)  Time elapsed: 2.688 sec  <<< FAILURE!
junit.framework.ComparisonFailure: Test M2_REPO value expected:<e...> but was:<E...>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at org.apache.maven.plugin.eclipse.EclipseWorkspaceTest.validateM2REPOVar(EclipseWorkspaceTest.java:95)
	at org.apache.maven.plugin.eclipse.EclipseWorkspaceTest.testWorkspace01(EclipseWorkspaceTest.java:52)
	at org.apache.maven.plugin.eclipse.EclipseWorkspaceTest.testWorkspace01(EclipseWorkspaceTest.java:52)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at junit.framework.TestCase.runTest(TestCase.java:154)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:132)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290)
	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:818)

testWorkspace02(org.apache.maven.plugin.eclipse.EclipseWorkspaceTest)  Time elapsed: 2.782 sec  <<< FAILURE!
junit.framework.ComparisonFailure: Test M2_REPO value expected:<e...> but was:<E...>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at org.apache.maven.plugin.eclipse.EclipseWorkspaceTest.validateM2REPOVar(EclipseWorkspaceTest.java:95)
	at org.apache.maven.plugin.eclipse.EclipseWorkspaceTest.testWorkspace02(EclipseWorkspaceTest.java:70)
	at org.apache.maven.plugin.eclipse.EclipseWorkspaceTest.testWorkspace02(EclipseWorkspaceTest.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at junit.framework.TestCase.runTest(TestCase.java:154)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:132)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290)
	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:818)


{noformat}

> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: addedTestFiles.patch, addedTestFiles.tgz, MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard van Nieuwenhoven updated MECLIPSE-242:
----------------------------------------------

    Attachment: addedTestFiles.tgz
                addedTestFiles.patch

The old svn problem ... i forgot to include the added files (pom and empty resource file of the test project)

just retested it, all test ok now.

the added files as patch and as tgz on the branch.

> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: addedTestFiles.patch, addedTestFiles.tgz, MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_108522 ] 

Richard van Nieuwenhoven commented on MECLIPSE-242:
---------------------------------------------------

That is strange! can it be that you forgot the M2_HOME variable before starting the build?

i did:
- delele local reposetory
- delete the project localy
- svn checkout http://svn.apache.org/repos/asf/maven/plugins/branches/MECLIPSE-242
- export M2_HOME=/tmp/maven-2.0.7
- export MAVEN_HOME=/tmp/maven-2.0.7
- cd MECLIPSE-242
- mvn install

and the result was

---------------
Results :

Tests run: 67, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8 minutes 6 seconds
[INFO] Finished at: Fri Sep 28 14:02:30 CEST 2007
[INFO] Final Memory: 10M/24M
[INFO] ------------------------------------------------------------------------

---------------


> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: addedTestFiles.patch, addedTestFiles.tgz, MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-242:
-------------------------------------

    Component/s: RAD support

> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Fox closed MECLIPSE-242.
------------------------------

      Assignee: Brian Fox
    Resolution: Fixed

Patch is merged and deployed

> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>            Assignee: Brian Fox
>         Attachments: addedTestFiles.patch, addedTestFiles.tgz, MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard van Nieuwenhoven updated MECLIPSE-242:
----------------------------------------------

    Attachment: MECLIPSE-242-for-2.5-SNAPSHOT.patch

This patch for the 2.5-SNAPSHOT trunk includes the necessary changes!
The patch also includes a test for the fix.



> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_108522 ] 

Richard van Nieuwenhoven edited comment on MECLIPSE-242 at 9/28/07 7:39 AM:
----------------------------------------------------------------------------

That is strange! can it be that you forgot the M2_HOME variable before starting the build?

i made the following steps:

- delete local reposetory
- delete the project localy
- svn checkout http://svn.apache.org/repos/asf/maven/plugins/branches/MECLIPSE-242
- export M2_HOME=/tmp/maven-2.0.7
- export MAVEN_HOME=/tmp/maven-2.0.7
- cd MECLIPSE-242
- mvn install

and the result was

---------------
Results :

Tests run: 67, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8 minutes 6 seconds
[INFO] Finished at: Fri Sep 28 14:02:30 CEST 2007
[INFO] Final Memory: 10M/24M
[INFO] ------------------------------------------------------------------------

---------------



 was:
That is strange! can it be that you forgot the M2_HOME variable before starting the build?

i did:
- delele local reposetory
- delete the project localy
- svn checkout http://svn.apache.org/repos/asf/maven/plugins/branches/MECLIPSE-242
- export M2_HOME=/tmp/maven-2.0.7
- export MAVEN_HOME=/tmp/maven-2.0.7
- cd MECLIPSE-242
- mvn install

and the result was

---------------
Results :

Tests run: 67, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8 minutes 6 seconds
[INFO] Finished at: Fri Sep 28 14:02:30 CEST 2007
[INFO] Final Memory: 10M/24M
[INFO] ------------------------------------------------------------------------

---------------


> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: addedTestFiles.patch, addedTestFiles.tgz, MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-242) RAD goal: missing lib-modules in .websettings

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_108460 ] 

Brian Fox commented on MECLIPSE-242:
------------------------------------

I applied the patch to http://svn.apache.org/repos/asf/maven/plugins/branches/MECLIPSE-242

I'm getting several test failures now:

{noformat}
Failed tests:
  testWorkspace01(org.apache.maven.plugin.eclipse.EclipseWorkspaceTest)
  testWorkspace02(org.apache.maven.plugin.eclipse.EclipseWorkspaceTest)

Tests in error:
  testProject5(org.apache.maven.plugin.eclipse.RadPluginTest)
  testProject5_2(org.apache.maven.plugin.eclipse.RadPluginTest)

Tests run: 67, Failures: 2, Errors: 2, Skipped: 0
{noformat}

If you can fix and send a patch from this branch, then I can get it committed.

> RAD goal: missing lib-modules in .websettings
> ---------------------------------------------
>
>                 Key: MECLIPSE-242
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-242
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: RAD support
>    Affects Versions: 2.3, 2.4
>         Environment: IBM Rational Application Developer 6.0.x
>            Reporter: Klaus Brunner
>         Attachments: MECLIPSE-242-for-2.5-SNAPSHOT.patch, RadWebSettingsWriter.java
>
>
> The eclipse:rad goal does not currently write the lib-modules element of the .websettings file. When developing with RAD and WAS, this results in dependent projects' code not being packaged and deployed as part of the WAR by the RAD build and deploy process. This applies to project dependencies only.
> Adapted version of RadWebSettingsWriter.java is attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira