You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 01:55:09 UTC

[GitHub] [flink] sunjincheng121 commented on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API

sunjincheng121 commented on issue #8488: [FLINK-12439][python] Add FileSystem Connector with CSV format support in Python Table API
URL: https://github.com/apache/flink/pull/8488#issuecomment-494621847
 
 
   One more comment: Please improve the description of PR, It's better to tell the reviewer which part you have a process in a special  way, such as: 
   - the PR do not add the `schema()` method for `OldCsv`
   - the PR only add one API for defines the watermark strategy
   - explan more why you add the `test_descriptor_end_to_end` test.
   Just a suggestion, and I know you allready did a good job. :)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services