You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/19 19:59:27 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #12492: Fix: "invalid date" for running task
ryanahamilton opened a new pull request #12492:
URL: https://github.com/apache/airflow/pull/12492
"Invalid date" date was displaying in the tooltip's "Ended" value for tasks currently running (not ended yet). I added the `isValid()` to confirm the Moment object is a valid one before displaying. Removed some redundancy within the function as well.
| Before | After |
|---|---|
| <img width="315" alt="Image 2020-11-19 at 2 53 19 PM" src="https://user-images.githubusercontent.com/3267/99717173-0f3c0a80-2a77-11eb-947e-a7ca6dc99570.png"> | <img width="319" alt="Image 2020-11-19 at 2 52 26 PM" src="https://user-images.githubusercontent.com/3267/99717179-1105ce00-2a77-11eb-9ab1-c61ab8ddb5ea.png"> |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12492: Fix: "invalid date" for running task
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12492:
URL: https://github.com/apache/airflow/pull/12492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12492: Fix: "invalid date" for running task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12492:
URL: https://github.com/apache/airflow/pull/12492#issuecomment-730604637
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org