[GitHub] [rocketmq] redlsz opened a new pull request, #6812: fix: litepull consumer send trace data failed

["redlsz (via GitHub)" <gi...@apache.org>]

redlsz opened a new pull request, #6812:
URL: https://github.com/apache/rocketmq/pull/6812

   Fixes #6809 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: litepull consumer send trace data failed [rocketmq]

["leizhiyuan (via GitHub)" <gi...@apache.org>]

leizhiyuan commented on PR #6812:
URL: https://github.com/apache/rocketmq/pull/6812#issuecomment-1920619143

   any update? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] redlsz commented on pull request #6812: fix: litepull consumer send trace data failed

["redlsz (via GitHub)" <gi...@apache.org>]

redlsz commented on PR #6812:
URL: https://github.com/apache/rocketmq/pull/6812#issuecomment-1681913266

   > Maybe we should refactor it to like ` DefaultMQPushConsumer`, initialize the `TraceDispatcher` on the constructor.
   
   It was before the [commit](https://github.com/apache/rocketmq/commit/2dc75d32099cf12e3caff0b32c7fa5fd1ce66a4c).
   
   And bug in this issue is also introduced by the commit above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org