[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #5524:
URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808797207



##########
File path: mm/iob/iob_alloc.c
##########
@@ -130,7 +130,27 @@ static FAR struct iob_s *iob_allocwait(bool throttled,
        * list.
        */
 
-      ret = nxsem_wait_uninterruptible(sem);
+      if (timeout == UINT_MAX)
+        {
+          ret = nxsem_wait_uninterruptible(sem);
+        }
+      else
+        {
+          struct timespec abstime;
+
+          DEBUGVERIFY(clock_gettime(CLOCK_REALTIME, &abstime));

Review comment:
       ```suggestion
             DEBUGVERIFY(clock_systime_timespec(&abstime) == 0);
   ```

##########
File path: mm/iob/iob_alloc.c
##########
@@ -93,7 +93,7 @@ static FAR struct iob_s *iob_alloc_committed(enum iob_user_e consumerid)
  *
  ****************************************************************************/
 
-static FAR struct iob_s *iob_allocwait(bool throttled,
+static FAR struct iob_s *iob_allocwait(bool throttled, unsigned int timeout,

Review comment:
       should me somehow make a hint that `timeout` has ms resolution?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org