You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "francisdb (JIRA)" <ji...@apache.org> on 2008/09/15 21:27:44 UTC
[jira] Created: (WICKET-1836) RequestUtils.toAbsolutePath() should
handle dot paths in the url
RequestUtils.toAbsolutePath() should handle dot paths in the url
----------------------------------------------------------------
Key: WICKET-1836
URL: https://issues.apache.org/jira/browse/WICKET-1836
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M3
Environment: linux jetty
Reporter: francisdb
Priority: Minor
String path = RequestUtils.toAbsolutePath(RequestCycle.get().urlFor(HomePage.class, new PageParameters()).toString());
if HomePage is mounted to / the url will be http://host/./ and should instead be http://host/
only double dots are translated, single dots should be removed
Some other remarks:
the implementation is using StringBuffer, that could be changed to StringBuilder.
toAbsolutepath should accept CharSequence instead of String (that will remove the need for the .toString() in the above sample
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1836) RequestUtils.toAbsolutePath() should
handle dot paths in the url
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1836.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M4
Assignee: Igor Vaynberg
i wasnt able to reproduce it, but i think i fixed it. feel free to open if its still broken
> RequestUtils.toAbsolutePath() should handle dot paths in the url
> ----------------------------------------------------------------
>
> Key: WICKET-1836
> URL: https://issues.apache.org/jira/browse/WICKET-1836
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: linux jetty
> Reporter: francisdb
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4-M4
>
>
> String path = RequestUtils.toAbsolutePath(RequestCycle.get().urlFor(HomePage.class, new PageParameters()).toString());
> if HomePage is mounted to / the url will be http://host/./ and should instead be http://host/
> only double dots are translated, single dots should be removed
> Some other remarks:
> the implementation is using StringBuffer, that could be changed to StringBuilder.
> toAbsolutepath should accept CharSequence instead of String (that will remove the need for the .toString() in the above sample
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1836) RequestUtils.toAbsolutePath()
should handle dot paths in the url
Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632318#action_12632318 ]
Bruno Borges commented on WICKET-1836:
--------------------------------------
Why the result for WebRequestCodingStrategy is set to "./" ?
Line@347
// We need to special-case links to the home page if we're at the
// same level.
if (result.length() == 0)
{
result = "./";
}
> RequestUtils.toAbsolutePath() should handle dot paths in the url
> ----------------------------------------------------------------
>
> Key: WICKET-1836
> URL: https://issues.apache.org/jira/browse/WICKET-1836
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: linux jetty
> Reporter: francisdb
> Priority: Minor
>
> String path = RequestUtils.toAbsolutePath(RequestCycle.get().urlFor(HomePage.class, new PageParameters()).toString());
> if HomePage is mounted to / the url will be http://host/./ and should instead be http://host/
> only double dots are translated, single dots should be removed
> Some other remarks:
> the implementation is using StringBuffer, that could be changed to StringBuilder.
> toAbsolutepath should accept CharSequence instead of String (that will remove the need for the .toString() in the above sample
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.