You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/07/06 00:03:02 UTC

Review Request: FLUME-1297: Wait till socket opens before starting tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5786/
-----------------------------------------------------------

Review request for Flume and Arvind Prabhakar.


Description
-------

Added a method to wait till port is open or a timeout of 20s, before starting test connection.


This addresses bug FLUME-1297.
    https://issues.apache.org/jira/browse/FLUME-1297


Diffs
-----

  flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestRpcClient.java 0c4b813 
  flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestRpcClientCommunicationFailure.java cd7a3dd 
  flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java e570d08 

Diff: https://reviews.apache.org/r/5786/diff/


Testing
-------


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1297: Wait till socket opens before starting tests.

Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5786/#review8982
-----------------------------------------------------------

Ship it!


+1

- Mike Percy


On July 5, 2012, 10:05 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5786/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 10:05 p.m.)
> 
> 
> Review request for Flume and Arvind Prabhakar.
> 
> 
> Description
> -------
> 
> Added a method to wait till port is open or a timeout of 20s, before starting test connection.
> 
> 
> This addresses bug FLUME-1297.
>     https://issues.apache.org/jira/browse/FLUME-1297
> 
> 
> Diffs
> -----
> 
>   flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestRpcClient.java 0c4b813 
>   flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestRpcClientCommunicationFailure.java cd7a3dd 
>   flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java e570d08 
> 
> Diff: https://reviews.apache.org/r/5786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>


Re: Review Request: FLUME-1297: Wait till socket opens before starting tests.

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5786/
-----------------------------------------------------------

(Updated July 5, 2012, 10:05 p.m.)


Review request for Flume and Arvind Prabhakar.


Description
-------

Added a method to wait till port is open or a timeout of 20s, before starting test connection.


This addresses bug FLUME-1297.
    https://issues.apache.org/jira/browse/FLUME-1297


Diffs (updated)
-----

  flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestRpcClient.java 0c4b813 
  flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestRpcClientCommunicationFailure.java cd7a3dd 
  flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java e570d08 

Diff: https://reviews.apache.org/r/5786/diff/


Testing
-------


Thanks,

Hari Shreedharan