You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/01/29 11:59:55 UTC
DO NOT REPLY [Bug 118845] New: [non-pro] htmlexpo gallery theme
dispayed on gallery
https://issues.apache.org/ooo/show_bug.cgi?id=118845
Bug #: 118845
Issue Type: DEFECT
Summary: [non-pro] htmlexpo gallery theme dispayed on gallery
Classification: Code
Product: framework
Version: current
Platform: All
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: P5
Component: code
AssignedTo: tm@openoffice.org
ReportedBy: arielch@apache.org
CC: ooo-issues@incubator.apache.org
On a non-product build, the htmlexpo gallery theme dispayed on gallery.
An error is displayed:
Error:
file:///home/ariel/OOo/AOOo/openoffice.org3/program/../basis-link/program/resource/galen-US.res
Class: String, Id: 6015. Cannot load resource!
Resource Stack
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Okay, looks good. Comitted, done.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
--- Comment #4 from Ariel Constenla-Haile <ar...@apache.org> ---
According to Regina: the theme is used in File > Wizard > Web page:
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
Assignee|arielch@apache.org |Armin.Le.Grand@me.com
--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
ALG: Reason is the htmlexpo theme of the gallery which was removed in svx, but
not in extras/scp2. Need to check and evtl. repair this
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
ALG: Thanks all for comments and findings.
Okay, let's go. Re-added ressource defines in *.src/*.hrc. Removed
sg25.sdg/sdv/thm after checking and seeing that these do not get installwed
anyways (what ensures they are not used by the wizard). Testing this...
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
--- Comment #5 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #4)
> According to Regina: the theme is used in File > Wizard > Web page:
The gallery theme is not used by the wizard, it uses the images directly from
the folder, so the gallery theme files can be safely removed.
See com.sun.star.wizards.web.IconsDialog.getImageUrls(Object listItem)
main/wizards/com/sun/star/wizards/web/IconsDialog.java
Removing the files
/opt/openoffice.org/basis3.4/share/gallery/sg25.sdg
/opt/openoffice.org/basis3.4/share/gallery/sg25.sdv
/opt/openoffice.org/basis3.4/share/gallery/sg25.thm
has no side effect on the Web Wizard.
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118845] [non-pro] htmlexpo gallery theme dispayed
on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
--- Comment #1 from Ariel Constenla-Haile <ar...@apache.org> 2012-01-29 11:01:59 UTC ---
Created attachment 77174
--> https://issues.apache.org/ooo/attachment.cgi?id=77174
Screenshot
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
--- Comment #3 from Ariel Constenla-Haile <ar...@apache.org> ---
The theme was removed with
impress210: #i105310# set tooltip for items and some refactoring
author Ocke.Janssen@oracle.com
Tue Feb 08 12:29:15 2011 +0100 (21 months ago)
changeset 276753 902597eed541
parent 276752 2f0f385e8b25
child 276754 fbdede3ae6d9
http://hg.services.openoffice.org/OOO340/rev/902597eed541
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/svx/gallery.hxx
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/source/gallery2/galtheme.src
http://hg.services.openoffice.org/OOO340/diff/902597eed541/svx/inc/galtheme.hrc
The underlying issue is that this commit removed all the code, including the
resource ID and the string, but it didn't remove the theme files.
Copy and paste from the dev@ mailing list:
* the private URL is stored in the theme itself as its name
* hidden themes are not displayed in the UI:
A hidden theme is one whose name begins with "private://gallery/hidden/"
see GalleryThemeEntry
sal_Bool IsHidden() const { return aName.SearchAscii(
"private://gallery/hidden/" ) == 0; }
This gallery theme is displayed on a non-pro build because the gallery theme is
not considered as hidden: though the name is really stored inside the theme
file, it is replaced in the GalleryThemeEntry constructor:
* the constructor gets the theme name as read from the theme file
* it tries to get the localized theme name from the resource first
* UniString::UniString( const ResId& rResId ) instead of creating an empty
string when the respective resource is missing (default behaviour on a pro
build), it returns a string with the error, see
http://opengrok.adfinis-sygroup.org/source/xref/aoo-trunk/main/tools/source/string/strucvt.cxx#195
* this string has a length > 0, then it replaces the original string as read
from the theme file
* this way, IsHidden will return false: the theme is not hidden as its name
does not start with private://gallery/hidden anymore
* then the theme is displayed in the UI on a non-pro build
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118845] [non-pro] htmlexpo gallery theme dispayed
on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|tm@openoffice.org |arielch@apache.org
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118845] [non-pro] htmlexpo gallery theme dispayed
on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ACCEPTED
Ever Confirmed|0 |1
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118845] [non-pro] htmlexpo gallery theme dispayed on gallery
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118845
--- Comment #8 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1415238 into trunk:
#118845# corrected missing ressource for gallery theme htmlexpo
--
You are receiving this mail because:
You are on the CC list for the bug.