You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@plc4x.apache.org by "Christofer Dutz (Jira)" <ji...@apache.org> on 2020/05/01 15:44:00 UTC

[jira] [Resolved] (PLC4X-107) Make the other drivers support the latest API changes

     [ https://issues.apache.org/jira/browse/PLC4X-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christofer Dutz resolved PLC4X-107.
-----------------------------------
      Assignee: Christofer Dutz  (was: Tim Mitsch)
    Resolution: Fixed

I think this issue can be closed as it seems that this job has been done (and at least I probably did it when re-writing the new drivers)

> Make the other drivers support the latest API changes
> -----------------------------------------------------
>
>                 Key: PLC4X-107
>                 URL: https://issues.apache.org/jira/browse/PLC4X-107
>             Project: Apache PLC4X
>          Issue Type: Task
>          Components: Driver-ADS, Driver-Ethernet/IP, Driver-Modbus
>            Reporter: Christofer Dutz
>            Assignee: Christofer Dutz
>            Priority: Major
>             Fix For: 0.7.0
>
>
> There have been API changes, that now must result in PlcRuntimeExceptions for all drivers except the S7 driver. This is because only this Driver implements the "parse" method and the default implementation simply throws this exception. 
> Even if technically now the Scraper no longer depends on the S7 driver, still it does, as this is the only driver that overrides this default method. 
> If API changes are made, we should ensure these are propagated to affected drivers or we will be having big problems of keeping stuff synced in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)