You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@forrest.apache.org by Juan Jose Pablos <ch...@apache.org> on 2004/12/20 11:12:19 UTC

Re: svn commit: r122833 - /forrest/trunk/main/build.xml

David,
As far as I know the error was to do with a missing  "site" directory.

We are trying to validate a site that is not longer under main. That was 
the reason I have removed. If you feel that we should validate the 
skinconf for :

./main/fresh-site/
./whiteboard/tests/whole-site/
./whiteboard/tests/basic/
./site-author/
./docs-author/
./plugins/wiki/
./plugins/simplified-docbook/
./plugins/rtf-output/
./plugins/IMSManifest/
./plugins/pluginTemplate/
./plugins/org.apache.forrest.plugin.pdf-output/
./plugins/org.apache.forrest.plugin.fbits/
./plugins/org.apache.forrest.plugin.logs/
./plugins/org.apache.forrest.plugin.photoGallery/
./plugins/org.apache.forrest.plugin.htmlArea/
./plugins/org.apache.forrest.plugin.OpenOffice.org/
./plugins/org.apache.forrest.plugin.text-output/
./plugins/org.apache.forrest.plugin.feeder/
./plugins/org.apache.forrest.plugin.pod-output/


Then:

<fileset dir="../" includes="**/skinconf.xml" />


WDYT?
Cheers,
Cheche

crossley@apache.org wrote:

>Author: crossley
>Date: Mon Dec 20 01:53:24 2004
>New Revision: 122833
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=122833
>Log:
>Stefan at Gump has tried to fix the failure of <xmlvalidate>
>by adding the ant-apache-resolver to gump's build of Ant.
>Roll back our change 122715 so we can test our gump build.
>
>Modified:
>   forrest/trunk/main/build.xml
>
>Modified: forrest/trunk/main/build.xml
>Url: http://svn.apache.org/viewcvs/forrest/trunk/main/build.xml?view=diff&rev=122833&p1=forrest/trunk/main/build.xml&r1=122832&p2=forrest/trunk/main/build.xml&r2=122833
>==============================================================================
>--- forrest/trunk/main/build.xml	(original)
>+++ forrest/trunk/main/build.xml	Mon Dec 20 01:53:24 2004
>@@ -156,6 +156,19 @@
>         <fileset dir="../lib/core" includes="*.jar" />
>       </classpath>
>     </taskdef>
>+    <!-- skinconf.xml -->
>+    <!-- FIXME: do we need to validate skinconf.xml to build forrest? -->
>+    <echo message="validating **/skinconf.xml ..."/>
>+    <xmlvalidate failonerror="true" lenient="no" warn="yes">
>+      <xmlcatalog id="xcat">
>+        <catalogpath>
>+          <pathelement
>+            location="./webapp/resources/schema/catalog.xcat"/>
>+        </catalogpath>
>+      </xmlcatalog>
>+      <fileset dir="./site"
>+        includes="**/skinconf.xml" />
>+    </xmlvalidate>
>     <!-- All stylesheets **/*.xsl -->
>     <echo message="validating stylesheets **/*.xsl ..."/>
>     <jing rngfile="./webapp/resources/schema/relaxng/xslt.rng">
>
>
>  
>

Re: svn commit: r122833 - /forrest/trunk/main/build.xml

Posted by Dave Brondsema <da...@brondsema.net>.

Quoting David Crossley <cr...@apache.org>:

> > If you feel that we should validate the 
> > skinconf for :
> 
> Well do you think that we should do this? We had another thread
> yesterday about this topic but we did not arrive at a decision.
> I think that we should somehow do such validation. Not sure if
> it all should be done in the main build. Perhaps just do fresh-site
> in the main build and the rest in a separate Ant task.
> 

The main build should just do the main build stuff, and not concern itself with
validation of our documentation.  The gump target, however, should run
'release-dist', and then run any/all the tests we have which would validate
skinconf as a part of their build.


-- 
Dave Brondsema : dave@brondsema.net 
http://www.brondsema.net : personal 
http://www.splike.com : programming 
http://csx.calvin.edu : student org

First Test suite for forrest (Re: Unit tests)

Posted by Juan Jose Pablos <ch...@apache.org>.

Hi,
Out of the software that was around I have modify the counit that Nico 
put in place.
There was a lot of his stuff that I did not put in place.  I tried to 
refactor to:

Easier to run within forrest "forrest run/site"
Easier to add new test 
output wrapper with forrest

Please let me know what do you think..

I am too tired today to add docs, but I will in a couple of days

Cheers,
Cheche

Re: Unit tests

Posted by Antonio Gallardo <ag...@agssa.net>.

Hi:

please see this:

http://wiki.apache.org/cocoon/UnitTestingStylesheetsAndPipelines

... a presentation on Ghent this year.

Best Regards,

Antonio Gallardo

On Mar, 21 de Diciembre de 2004, 2:57, Nicola Ken Barozzi dijo:
> Ross Gardler wrote:
>> Juan Jose Pablos wrote:
>>
>>> Ross Gardler wrote:
>>>
>>>> Yes, we have had some good results from Canoo Webtest when testing
>>>> things like this. Th test target would need to start a server then
>>>> run a series of requests against a set of test inputs (see
>>>> http://webtest.canoo.com/webtest/manual/WebTestHome.html )
>>>
>>> but that is only html stuff. I would like to get something that we can
>>> use to test xml (xdoc,oo,xhtml) output.
>>
>> Good point.
>
> IIRC Cocoon uses Anteater.
>
> http://aft.sourceforge.net/
>
> --
> Nicola Ken Barozzi                   nicolaken@apache.org
>              - verba volant, scripta manent -
>     (discussions get forgotten, just code remains)
> ---------------------------------------------------------------------
>

Re: Unit tests

Posted by Nicola Ken Barozzi <ni...@apache.org>.

Ross Gardler wrote:
> Juan Jose Pablos wrote:
> 
>> Ross Gardler wrote:
>>
>>> Yes, we have had some good results from Canoo Webtest when testing 
>>> things like this. Th test target would need to start a server then 
>>> run a series of requests against a set of test inputs (see 
>>> http://webtest.canoo.com/webtest/manual/WebTestHome.html )
>>
>> but that is only html stuff. I would like to get something that we can 
>> use to test xml (xdoc,oo,xhtml) output.
> 
> Good point.

IIRC Cocoon uses Anteater.

http://aft.sourceforge.net/

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------

Re: Unit tests

Posted by Ross Gardler <rg...@apache.org>.

Juan Jose Pablos wrote:
> Ross Gardler wrote:
> 
>> Yes, we have had some good results from Canoo Webtest when testing 
>> things like this. Th test target would need to start a server then run 
>> a series of requests against a set of test inputs (see 
>> http://webtest.canoo.com/webtest/manual/WebTestHome.html )
> 
> 
> but that is only html stuff. I would like to get something that we can 
> use to test xml (xdoc,oo,xhtml) output.

Good point.

> Are they able to take <p/> and <p></p> as same results?

Yes, I believe so.

Ross

Re: Unit tests

Posted by Juan Jose Pablos <ch...@apache.org>.

Ross Gardler wrote:

> Yes, we have had some good results from Canoo Webtest when testing 
> things like this. Th test target would need to start a server then run 
> a series of requests against a set of test inputs (see 
> http://webtest.canoo.com/webtest/manual/WebTestHome.html )

but that is only html stuff. I would like to get something that we can 
use to test xml (xdoc,oo,xhtml) output.
Are they able to take <p/> and <p></p> as same results?

>
> Right now all the plugins do when tested is they build the documentation.
>
I am looking right now on http://xsltunit.org/ , But I am not 100% sure 
that we can incorporate it on forrest. I know nothing about licenses..

Re: Unit tests

Posted by Ross Gardler <rg...@apache.org>.

Juan Jose Pablos wrote:
> Dave Brondsema wrote:
> 
>> What sort of XML unit testing do you want to do besides validate 
>> against a DTD?
>>
>>  
>>
> that we are doing a proper input transformation from formats like:
> wiki,sdocbook,oo and others.

Yes, we have had some good results from Canoo Webtest when testing 
things like this. Th test target would need to start a server then run a 
series of requests against a set of test inputs (see 
http://webtest.canoo.com/webtest/manual/WebTestHome.html )

Right now all the plugins do when tested is they build the documentation.

Ross

Re: Unit tests

Posted by Juan Jose Pablos <ch...@apache.org>.

Dave Brondsema wrote:

>What sort of XML unit testing do you want to do besides validate against a DTD?
>
>  
>
that we are doing a proper input transformation from formats like:
wiki,sdocbook,oo and others.

>Other unit tests and integration tests we should look in to are ones to verify
>that the different parts of pipelines do the proper transformations. 
>

I had in mind the same ones :-)

> I think
>the nature of Forrest (and Cocoon) make it hard to test specific things (e.g.
>make sure that .jspwiki conversion "works", whatever that means, while ignoring
>all HTML from the skin, menu, header, etc).
>
We used to have a test-site target to test the intermediate format

>  Some places for us to start looking
>are:
>
>http://wiki.apache.org/cocoon/UnitTestingStylesheetsAndPipelines
>http://htmlunit.sourceforge.net/
>http://products.actimind.com/actiWATE/ 
>
>  
>
I will have a look thanks!

Re: Unit tests (was: svn commit: r122833 - /forrest/trunk/main/build.xml)

Posted by Dave Brondsema <da...@brondsema.net>.

Quoting Juan Jose Pablos <ch...@apache.org>:

> 
> >>If you feel that we should validate the 
> >>skinconf for :
> >>    
> >>
> >
> >Well do you think that we should do this? 
> >
> 
> Well, we are validating a configuration file that does not have all 
> possible options. So this feels like a partial test.
> 
> I think that we (forrest) need to have more test units, and this 
> validation task should be more over there .
> How dificult can be to setup Junit for xml?
> 

What sort of XML unit testing do you want to do besides validate against a DTD?

Other unit tests and integration tests we should look in to are ones to verify
that the different parts of pipelines do the proper transformations.  I think
the nature of Forrest (and Cocoon) make it hard to test specific things (e.g.
make sure that .jspwiki conversion "works", whatever that means, while ignoring
all HTML from the skin, menu, header, etc).  Some places for us to start looking
are:

http://wiki.apache.org/cocoon/UnitTestingStylesheetsAndPipelines
http://htmlunit.sourceforge.net/
http://products.actimind.com/actiWATE/ 

-- 
Dave Brondsema : dave@brondsema.net 
http://www.brondsema.net : personal 
http://www.splike.com : programming 
http://csx.calvin.edu : student org