You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "prateekm (via GitHub)" <gi...@apache.org> on 2023/04/07 17:50:08 UTC
[GitHub] [samza] prateekm opened a new pull request, #1663: Wait for pending commits to finish during shutdown.
prateekm opened a new pull request, #1663:
URL: https://github.com/apache/samza/pull/1663
Issue: BlobStoreStateBackendIntegrationTest.testStopAndRestart fails occassionally if SamzaContainer shuts down before pending commits for its tasks are complete. Note: This issue does not affect correctness of commits, but does affect test reliability.
Fix: 1) Wait for pending commits to complete before shutting the container down. 2) Shut down commitThreadPool after the pending commits are complete (otherwise queued tasks requried to complete commits will be cancelled and commits will be unsuccessful).
Test: BlobStoreStateBackendIntegrationTest.testStopAndRestart passes in a loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] prateekm commented on pull request #1663: Wait for pending commits to finish during shutdown.
Posted by "prateekm (via GitHub)" <gi...@apache.org>.
prateekm commented on PR #1663:
URL: https://github.com/apache/samza/pull/1663#issuecomment-1500503523
@bharathkk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] prateekm commented on pull request #1663: Wait for pending commits to finish during shutdown.
Posted by "prateekm (via GitHub)" <gi...@apache.org>.
prateekm commented on PR #1663:
URL: https://github.com/apache/samza/pull/1663#issuecomment-1502392224
This seems to time out builds, presumably due to test timeouts. Will debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org