[jira] Resolved: (HARMONY-42) com.ibm.io.nio.FileChannel is not fully implemented

["Tim Ellison (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/HARMONY-42?page=all ]
     
Tim Ellison resolved HARMONY-42:
--------------------------------

    Resolution: Fixed

Paulex / Richard,

I've had a look at the patches you sent and applied them at repo revision 376690.

I have the following comments (note especially #6):

1.  Added a missing ASF copyright statment to IMemorySystem.h,
2.  nio/OSFileSystemWin32.c#OSFileSystem_transferImpl has a number of printf's in there that should be removed (e.g. printf("Error getJavaIoFileDescriptorContentsAsAPointer!\n"); )
3. same thing in port/hymmap.c#hymmap_map_filehandler (e.g. printf("print this to show in this function"); ) -- this also has a very strange code layout !
4. I have added some missing exports from the exp & def files for the new JNI functions you defined
5.  I see a few TODO's in there, like IPv6 support on a couple fo functions -- that's ok, but if you do the work please send it along.
6. I have *not* applied the modifications you made to the portlib to extend the mmap functionality; and therefore I have modified the OSMemory#mmap method to throw a NotYetImplementedException.  I'll discuss this on the mailing list.

Please open a new JIRA for further patches/work in this area -- and thank you very much for your contribution.

> com.ibm.io.nio.FileChannel is not fully implemented
> ---------------------------------------------------
>
>          Key: HARMONY-42
>          URL: http://issues.apache.org/jira/browse/HARMONY-42
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>  Attachments: FileChannel_patch.zip, Harmony42-IFileSystem-patch.txt, Harmony42-IMemorySystem-patch.txt, Harmony42-java_io_FileChannelFactory-patch.txt, Harmony42-java_io_FileOutputStream-patch.txt, IFileSystem.java
>
> Many functions of FileChannel, such as memory map, transfer, gathering/scattering I/O are not implemented. Further, three classes in java.io, FileInputStream FileOutputStream, and RandomAccessFile, are related to java.nio.FileChannel, so that they can be refactored to base on same JNI interface, just like the network channels and sockets. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira