You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by aw...@apache.org on 2018/11/12 21:04:25 UTC
cassandra git commit: Lower default chunk_length_in_kb from 64kb to
16kb
Repository: cassandra
Updated Branches:
refs/heads/trunk 801cb70ee -> caf50de31
Lower default chunk_length_in_kb from 64kb to 16kb
Patch by Ariel Weisberg; Reviewed by Jon Haddad for CASSANDRA-13241
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/caf50de3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/caf50de3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/caf50de3
Branch: refs/heads/trunk
Commit: caf50de31b034ed77140b3c1597e7ca6ddc44e17
Parents: 801cb70
Author: Ariel Weisberg <aw...@apple.com>
Authored: Mon Oct 22 16:44:33 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Mon Nov 12 16:03:16 2018 -0500
----------------------------------------------------------------------
CHANGES.txt | 1 +
NEWS.txt | 3 +++
src/java/org/apache/cassandra/schema/CompressionParams.java | 2 +-
.../cassandra/cql3/validation/operations/AlterTest.java | 8 ++++----
.../cassandra/cql3/validation/operations/CreateTest.java | 8 ++++----
5 files changed, 13 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/caf50de3/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index aaea773..5fd28bc 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0
+ * Lower default chunk_length_in_kb from 64kb to 16kb (CASSANDRA-13241)
* Startup checker should wait for count rather than percentage (CASSANDRA-14297)
* Fix incorrect sorting of replicas in SimpleStrategy.calculateNaturalReplicas (CASSANDRA-14862)
* Partitioned outbound internode TCP connections can occur when nodes restart (CASSANDRA-14358)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/caf50de3/NEWS.txt
----------------------------------------------------------------------
diff --git a/NEWS.txt b/NEWS.txt
index 63c4a47..af28b6e 100644
--- a/NEWS.txt
+++ b/NEWS.txt
@@ -108,6 +108,9 @@ New features
Upgrading
---------
+ - CASSANDRA-13241 lowered the default chunk_lengh_in_kb for compresesd tables from
+ 64kb to 16kb. For highly compressible data this can have a noticeable impact
+ on space utilization. You may want to consider manually specifying this value.
- Additional columns have been added to system_distributed.repair_history,
system_traces.sessions and system_traces.events. As a result select * queries
againsts these tables will fail and generate an error in the log
http://git-wip-us.apache.org/repos/asf/cassandra/blob/caf50de3/src/java/org/apache/cassandra/schema/CompressionParams.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/schema/CompressionParams.java b/src/java/org/apache/cassandra/schema/CompressionParams.java
index d644c56..2563111 100644
--- a/src/java/org/apache/cassandra/schema/CompressionParams.java
+++ b/src/java/org/apache/cassandra/schema/CompressionParams.java
@@ -55,7 +55,7 @@ public final class CompressionParams
private static volatile boolean hasLoggedChunkLengthWarning;
private static volatile boolean hasLoggedCrcCheckChanceWarning;
- public static final int DEFAULT_CHUNK_LENGTH = 65536;
+ public static final int DEFAULT_CHUNK_LENGTH = 1024 * 16;
public static final double DEFAULT_MIN_COMPRESS_RATIO = 0.0; // Since pre-4.0 versions do not understand the
// new compression parameter we can't use a
// different default value.
http://git-wip-us.apache.org/repos/asf/cassandra/blob/caf50de3/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
----------------------------------------------------------------------
diff --git a/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java b/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
index a792bcb..79db6f2 100644
--- a/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
+++ b/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
@@ -347,7 +347,7 @@ public class AlterTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.LZ4Compressor")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.LZ4Compressor")));
execute("ALTER TABLE %s WITH compression = { 'class' : 'SnappyCompressor', 'chunk_length_in_kb' : 32 };");
@@ -374,7 +374,7 @@ public class AlterTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.LZ4Compressor", "min_compress_ratio", "2.0")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.LZ4Compressor", "min_compress_ratio", "2.0")));
execute("ALTER TABLE %s WITH compression = { 'class' : 'LZ4Compressor', 'min_compress_ratio' : 1 };");
@@ -383,7 +383,7 @@ public class AlterTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.LZ4Compressor", "min_compress_ratio", "1.0")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.LZ4Compressor", "min_compress_ratio", "1.0")));
execute("ALTER TABLE %s WITH compression = { 'class' : 'LZ4Compressor', 'min_compress_ratio' : 0 };");
@@ -392,7 +392,7 @@ public class AlterTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.LZ4Compressor")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.LZ4Compressor")));
execute("ALTER TABLE %s WITH compression = { 'class' : 'SnappyCompressor', 'chunk_length_in_kb' : 32 };");
execute("ALTER TABLE %s WITH compression = { 'enabled' : 'false'};");
http://git-wip-us.apache.org/repos/asf/cassandra/blob/caf50de3/test/unit/org/apache/cassandra/cql3/validation/operations/CreateTest.java
----------------------------------------------------------------------
diff --git a/test/unit/org/apache/cassandra/cql3/validation/operations/CreateTest.java b/test/unit/org/apache/cassandra/cql3/validation/operations/CreateTest.java
index 37605d6..1c3b449 100644
--- a/test/unit/org/apache/cassandra/cql3/validation/operations/CreateTest.java
+++ b/test/unit/org/apache/cassandra/cql3/validation/operations/CreateTest.java
@@ -564,7 +564,7 @@ public class CreateTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.LZ4Compressor")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.LZ4Compressor")));
createTable("CREATE TABLE %s (a text, b int, c int, primary key (a, b))"
+ " WITH compression = { 'class' : 'SnappyCompressor', 'chunk_length_in_kb' : 32 };");
@@ -604,7 +604,7 @@ public class CreateTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.SnappyCompressor", "min_compress_ratio", "2.0")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.SnappyCompressor", "min_compress_ratio", "2.0")));
createTable("CREATE TABLE %s (a text, b int, c int, primary key (a, b))"
+ " WITH compression = { 'sstable_compression' : 'SnappyCompressor', 'min_compress_ratio' : 1 };");
@@ -614,7 +614,7 @@ public class CreateTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.SnappyCompressor", "min_compress_ratio", "1.0")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.SnappyCompressor", "min_compress_ratio", "1.0")));
createTable("CREATE TABLE %s (a text, b int, c int, primary key (a, b))"
+ " WITH compression = { 'sstable_compression' : 'SnappyCompressor', 'min_compress_ratio' : 0 };");
@@ -624,7 +624,7 @@ public class CreateTest extends CQLTester
SchemaKeyspace.TABLES),
KEYSPACE,
currentTable()),
- row(map("chunk_length_in_kb", "64", "class", "org.apache.cassandra.io.compress.SnappyCompressor")));
+ row(map("chunk_length_in_kb", "16", "class", "org.apache.cassandra.io.compress.SnappyCompressor")));
createTable("CREATE TABLE %s (a text, b int, c int, primary key (a, b))"
+ " WITH compression = { 'sstable_compression' : '', 'chunk_length_kb' : 32 };");
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org