You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/25 16:50:24 UTC
[GitHub] [spark] gengliangwang opened a new pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
gengliangwang opened a new pull request #30500:
URL: https://github.com/apache/spark/pull/30500
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Remove the fixed width style of class `container-fluid-div`. So that the UI looks clean when the text is long.
2. Add one space between a checkbox and the text on the right side, which is consistent with the stage page.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The width of class `container-fluid-div` is set as 200px after https://github.com/apache/spark/pull/21688 . This makes the checkbox in the executor page messy.
We should remove the style.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manual test.
After the changes:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734019335
@gengliangwang, do you want to port this back? It has a conflict to resolve so I didn't port it back for now. I will leave it to you to port it back after resolving the conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-733913452
**[Test build #131788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131788/testReport)** for PR 30500 at commit [`8f4700e`](https://github.com/apache/spark/commit/8f4700e5caf9f2e82315ea616842c0dd8f9fe711).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30500:
URL: https://github.com/apache/spark/pull/30500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734060099
Cool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734019128
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-733835284
**[Test build #131788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131788/testReport)** for PR 30500 at commit [`8f4700e`](https://github.com/apache/spark/commit/8f4700e5caf9f2e82315ea616842c0dd8f9fe711).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734038523
@HyukjinKwon I will port this to branch-3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-733835284
**[Test build #131788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131788/testReport)** for PR 30500 at commit [`8f4700e`](https://github.com/apache/spark/commit/8f4700e5caf9f2e82315ea616842c0dd8f9fe711).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-733922318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-733922318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang removed a comment on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
gengliangwang removed a comment on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734038523
@HyukjinKwon I will port this to branch-3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734058182
@HyukjinKwon I just found that the issue doesn't exist until https://github.com/apache/spark/pull/30186. Before that the text was short.
I have updated the affects version in the jira. No need to backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30500: [SPARK-33562][UI] Improve the style of the checkbox in executor page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30500:
URL: https://github.com/apache/spark/pull/30500#issuecomment-734019128
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org