[GitHub] [hudi] codope commented on a diff in pull request #6154: [HUDI-4434] Disable EmrFS file metadata caching and EMR Spark's data prefetcher feature

[GitBox <gi...@apache.org>]

codope commented on code in PR #6154:
URL: https://github.com/apache/hudi/pull/6154#discussion_r927021771


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -56,6 +56,9 @@ class DefaultSource extends RelationProvider
       // Enable "passPartitionByAsOptions" to support "write.partitionBy(...)"
       spark.conf.set("spark.sql.legacy.sources.write.passPartitionByAsOptions", "true")
     }
+    // Revisit EMR Spark and EMRFS incompatibilities, for now disable
+    spark.conf.set("spark.sql.dataPrefetch.enabled", "false")
+    spark.sparkContext.hadoopConfiguration.set("fs.s3.metadata.cache.expiration.seconds", "0")

Review Comment:
   Shouldn't this be guarded by a Hudi config as it is an issue on EmrFs?
   Also, I did not find any documentation for `fs.s3.metadata.cache.expiration.seconds` config in https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/s3guard.html?
   Have we tested this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org