You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 08:29:06 UTC
[GitHub] [flink] TsReaper opened a new pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
TsReaper opened a new pull request #13764:
URL: https://github.com/apache/flink/pull/13764
## What is the purpose of the change
Due to CALCITE-4351 `FlinkRelMdDistinctRowCount#getDistinctRowCount(Calc)` will always return 0 when number of rows are large.
This PR introduces our own `FlinkRelMdUtil#numDistinctVals` to treat small and large inputs in different ways. For small inputs we use the more precise `RelMdUtil#numDistinctVals` and for large inputs we copy the old, approximated implementation of `RelMdUtil#numDistinctVals`.
This is a temporary solution. When CALCITE-4351 is fixed we should revert this commit.
## Brief change log
- Introduce `FlinkRelMdUtil#numDistinctVals`
## Verifying this change
This change is already covered by existing tests, also this change added tests and can be verified by running the added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715216405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170",
"triggerID" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 954b1d5490d4355fde4a175b1c4023f56b872260 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715216405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170",
"triggerID" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 954b1d5490d4355fde4a175b1c4023f56b872260 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715179402
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 954b1d5490d4355fde4a175b1c4023f56b872260 (Fri Oct 23 08:32:41 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19780).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715216405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170",
"triggerID" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"triggerType" : "PUSH"
}, {
"hash" : "f52530104b74c660cb2665e991b79e0391eec842",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8281",
"triggerID" : "f52530104b74c660cb2665e991b79e0391eec842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 954b1d5490d4355fde4a175b1c4023f56b872260 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170)
* f52530104b74c660cb2665e991b79e0391eec842 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715216405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170",
"triggerID" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"triggerType" : "PUSH"
}, {
"hash" : "f52530104b74c660cb2665e991b79e0391eec842",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8281",
"triggerID" : "f52530104b74c660cb2665e991b79e0391eec842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52530104b74c660cb2665e991b79e0391eec842 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715216405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 954b1d5490d4355fde4a175b1c4023f56b872260 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe merged pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
godfreyhe merged pull request #13764:
URL: https://github.com/apache/flink/pull/13764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13764: [FLINK-19780][table-planner-blink] Introduce FlinkRelMdUtil#numDistinctVals to work around precision problem in Calcite's implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13764:
URL: https://github.com/apache/flink/pull/13764#issuecomment-715216405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170",
"triggerID" : "954b1d5490d4355fde4a175b1c4023f56b872260",
"triggerType" : "PUSH"
}, {
"hash" : "f52530104b74c660cb2665e991b79e0391eec842",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52530104b74c660cb2665e991b79e0391eec842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 954b1d5490d4355fde4a175b1c4023f56b872260 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8170)
* f52530104b74c660cb2665e991b79e0391eec842 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org