[whimsy] branch master updated: No need to raise error if _.system fails; done internally

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 85feb08  No need to raise error if _.system fails; done internally
85feb08 is described below

commit 85feb08c1bdd34908bebd13a42eaf6296e8d857c
Author: Sebb <se...@apache.org>
AuthorDate: Thu Jun 4 12:33:00 2020 +0100

    No need to raise error if _.system fails; done internally
---
 lib/whimsy/asf/svn.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index 0d2a688..1338ea7 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -530,7 +530,7 @@ module ASF
         if env
           syscmd << ['--username', env.user, '--password', env.password] # TODO --password-from-stdin
         end
-        _.system syscmd or raise Exception.new("svnmucc command failed")
+        _.system syscmd
       ensure
         FileUtils.rm_rf tmpdir unless temp
       end
@@ -587,7 +587,7 @@ module ASF
           ['--username', env.user, '--password', env.password],
           '--no-auth-cache',
           parenturl, tmpdir
-          ] or raise Exception.new("Failed to create checkout")
+          ]
 
         # checkout the file
         _.system ['svn', 'update',
@@ -595,7 +595,7 @@ module ASF
           ['--username', env.user, '--password', env.password],
           '--no-auth-cache',
           outputfile
-          ] or raise Exception.new("Failed to checkout file")
+          ]
 
         # N.B. the revision is required for the svnmucc put to prevent overriding a previous update
         # this is why the file is checked out rather than just extracted