[jira] [Commented] (CASSANDRA-4763) SSTableLoader shouldn't get keyspace from path

["Joshua McKenzie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197498#comment-15197498 ] 

Joshua McKenzie commented on CASSANDRA-4763:
--------------------------------------------

[~yukim]: is this still relevant?

> SSTableLoader shouldn't get keyspace from path
> ----------------------------------------------
>
>                 Key: CASSANDRA-4763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4763
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Nick Bailey
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 2.1.x
>
>
> SSTableLoader currently gets the keyspace it is going to load to from the path of the directoy of sstables it is loading. This isn't really documented (or I didn't see it), but also isn't really a good way of doing it in general.
> {noformat}
> this.keyspace = directory.getParentFile().getName();
> {noformat}
> We should probably just let users pass the name in. If you are loading a snapshot the file names will have the keyspace which is slightly better but people manually creating their own sstables might not format them the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)