You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "deepthi912 (via GitHub)" <gi...@apache.org> on 2026/05/12 20:27:52 UTC

[PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode prune races [pinot]

deepthi912 opened a new pull request, #18478:
URL: https://github.com/apache/pinot/pull/18478

   ## Problem
   
   `SegmentPrunerService.removeEmptySegments` calls `UpsertUtils.hasNoQueryableDocs` to drop empty segments before query execution. Today that method reads the segment's **live** `ThreadSafeMutableRoaringBitmap` via `IndexSegment.getQueryableDocIds()` / `getValidDocIds()`.
   
   For upsert tables running with consistency mode `SYNC` or `SNAPSHOT`, the live bitmap can diverge from the per-query snapshot maintained by `UpsertViewManager` between refreshes. So a "no queryable docs here" reading on the live bitmap can cause the pruner to drop a segment that is non-empty in the snapshot view the query is about to scan — producing wrong row counts.
   
   ## Change
   
   Surface the snapshot to the pruner without breaking the SPI ⇄ impl layering. The dependency direction stays the same (`pinot-segment-local` → `pinot-segment-spi`), and no new module dependencies are added.
   
   | File | Module | Change |
   | --- | --- | --- |
   | `IndexSegment.java` | `pinot-segment-spi` | +2 default methods: `@Nullable MutableRoaringBitmap getQueryableDocIdsSnapshot()` and `boolean isUpsertConsistencyModeEnabled()`. Both default to `null` / `false`, so non-upsert segments are unaffected. |
   | `PartitionUpsertMetadataManager.java` | `pinot-segment-local` | +1 method on the interface: `@Nullable UpsertViewManager getUpsertViewManager()`. `BasePartitionUpsertMetadataManager` already implements it, so no impl changes. |
   | `UpsertViewManager.java` | `pinot-segment-local` | +1 public lookup `getQueryableDocIdsSnapshot(IndexSegment)`. Lock-free: volatile read of `_segmentQueryableDocIdsMap` + map lookup. Writers replace the map reference atomically under `_upsertViewLock` (write lock), never mutating the old one. |
   | `ImmutableSegmentImpl.java` / `MutableSegmentImpl.java` | `pinot-segment-local` | Override both SPI methods, delegating to the partition's `UpsertViewManager`. Existence of the view manager is exactly equivalent to consistency mode being on (`BasePartitionUpsertMetadataManager.java:159–167`). |
   | `UpsertUtils.java` | `pinot-segment-local` | `hasNoQueryableDocs` now: (1) consult the snapshot first; (2) if consistency mode is on but the snapshot is not yet populated for this segment — first refresh hasn't run or segment just tracked — return `false` conservatively; (3) otherwise fall back to live bitmaps as before. |
   
   Behavior on non-consistency-mode tables and on non-upsert tables is **identical** to today.
   
   ## Tests
   
   New `UpsertUtilsTest` with 7 cases — passing locally:
   
   ```
   [INFO] Running org.apache.pinot.segment.local.upsert.UpsertUtilsTest
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
   ```
   
   | Case | Expected |
   | --- | --- |
   | non-upsert, live queryable bitmap empty | `true` |
   | non-upsert, live queryable bitmap non-empty | `false` |
   | non-upsert, queryable `null`, valid bitmap empty | `true` |
   | non-upsert, both bitmaps `null` | `false` |
   | **consistency mode**, snapshot empty, live bitmap non-empty | `true` (snapshot wins) |
   | **consistency mode**, snapshot non-empty, live bitmap empty | `false` (snapshot wins) |
   | **consistency mode**, snapshot absent, live bitmap empty | `false` (conservative deferral) |
   
   Existing `UpsertViewManagerTest` still passes (no regressions on the touched API).
   
   ## Test plan
   
   - [x] `mvn -pl pinot-segment-spi,pinot-segment-local,pinot-core -am compile` — clean
   - [x] `mvn -pl pinot-segment-local test -Dtest=UpsertUtilsTest` — 7/7 pass
   - [x] `mvn -pl pinot-segment-local test -Dtest=UpsertViewManagerTest` — no regressions
   - [ ] CI green
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode pruning [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #18478:
URL: https://github.com/apache/pinot/pull/18478#discussion_r3231900551


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/IndexSegment.java:
##########
@@ -106,6 +107,31 @@ default DataSource getDataSource(String column) {
   @Nullable
   ThreadSafeMutableRoaringBitmap getQueryableDocIds();
 
+  /**
+   * Returns the queryable doc-id bitmap from the upsert snapshot view if the table has consistency mode
+   * (SYNC or SNAPSHOT) enabled and this segment is included in the latest refresh; otherwise returns {@code null}.
+   *
+   * <p>Callers that need a consistent view across segments (e.g. query-time empty-segment pruning) should
+   * prefer this over {@link #getQueryableDocIds()}, which is the segment's live bitmap and can drift from the
+   * per-query snapshot between refreshes.
+   */
+  @Nullable
+  default MutableRoaringBitmap getQueryableDocIdsSnapshot() {

Review Comment:
   It will be much cleaner if you directly add `hasNoQueryableDocs()` to `IndexSegment`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode pruning [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #18478:
URL: https://github.com/apache/pinot/pull/18478#discussion_r3234046949


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertViewManager.java:
##########
@@ -306,6 +307,19 @@ Map<IndexSegment, MutableRoaringBitmap> getSegmentQueryableDocIdsMap() {
     return _segmentQueryableDocIdsMap;
   }
 
+  /**
+   * Returns the queryable doc-id snapshot for the given segment from the most recent refresh, or
+   * {@code null} if no refresh has happened yet or the segment is not in the current view.
+   *
+   * <p>Lock-free: reads the volatile map reference and does a single lookup. Writers replace the map
+   * reference atomically under {@link #_upsertViewLock} (write lock), so the returned bitmap is the
+   * frozen snapshot of that refresh.
+   */
+  @Nullable
+  public MutableRoaringBitmap getQueryableDocIdsSnapshot(IndexSegment segment) {
+    return _segmentQueryableDocIdsMap.get(segment);

Review Comment:
   `UpsertUtils.hasNoQueryableDocs()` now calls `segment.getQueryableDocIdsSnapshot()` before it checks `isUpsertConsistencyModeEnabled()`, but this getter unconditionally dereferences `_segmentQueryableDocIdsMap`. In `SYNC` mode that map is never populated by the normal query path, and in `SNAPSHOT` mode it is still null before the first refresh, so empty-segment pruning can throw `NullPointerException` instead of conservatively returning `false`. Please null-guard the map here (or only expose this getter once a snapshot map exists) so consistency-mode tables do not regress into query failures.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode pruning [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #18478:
URL: https://github.com/apache/pinot/pull/18478#discussion_r3238224976


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -138,4 +139,11 @@ public interface PartitionUpsertMetadataManager extends Closeable {
    * segments can be processed by the server even before they get included in the broker's routing table.
    */
   void trackNewlyAddedSegment(String segmentName);
+
+  /**
+   * Returns the upsert view manager that maintains the per-segment queryable-doc-id snapshot for consistency-mode
+   * upsert tables, or {@code null} when consistency mode is not enabled for this partition.
+   */
+  @Nullable
+  UpsertViewManager getUpsertViewManager();

Review Comment:
   (minor) Add `@Override` and `@Nullable` to `BasePartitionUpsertMetadataManager`



##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/IndexSegment.java:
##########
@@ -106,6 +106,22 @@ default DataSource getDataSource(String column) {
   @Nullable
   ThreadSafeMutableRoaringBitmap getQueryableDocIds();
 
+  /**

Review Comment:
   (minor) It will be more readable in markdown style. Same for other new added javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode pruning [pinot]

Posted by "deepthi912 (via GitHub)" <gi...@apache.org>.
deepthi912 commented on code in PR #18478:
URL: https://github.com/apache/pinot/pull/18478#discussion_r3238307306


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -138,4 +139,11 @@ public interface PartitionUpsertMetadataManager extends Closeable {
    * segments can be processed by the server even before they get included in the broker's routing table.
    */
   void trackNewlyAddedSegment(String segmentName);
+
+  /**
+   * Returns the upsert view manager that maintains the per-segment queryable-doc-id snapshot for consistency-mode
+   * upsert tables, or {@code null} when consistency mode is not enabled for this partition.
+   */
+  @Nullable
+  UpsertViewManager getUpsertViewManager();

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode pruning [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18478:
URL: https://github.com/apache/pinot/pull/18478#issuecomment-4435190044

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18478?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `9.52381%` with `19 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.76%. Comparing base ([`d88887e`](https://app.codecov.io/gh/apache/pinot/commit/d88887ed57da45fd21d979e8a9ce99738cf6d5a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`41591d0`](https://app.codecov.io/gh/apache/pinot/commit/41591d01c7e6ae55376c0b6304f3113c02382c68?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/18478?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...local/indexsegment/mutable/MutableSegmentImpl.java](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Findexsegment%2Fmutable%2FMutableSegmentImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...l/indexsegment/immutable/ImmutableSegmentImpl.java](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Findexsegment%2Fimmutable%2FImmutableSegmentImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRJbXBsLmphdmE=) | 16.66% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/pinot/segment/local/upsert/UpsertUtils.java](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Fupsert%2FUpsertUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91cHNlcnQvVXBzZXJ0VXRpbHMuamF2YQ==) | 20.00% | [2 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../pinot/segment/local/upsert/UpsertViewManager.java](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Fupsert%2FUpsertViewManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91cHNlcnQvVXBzZXJ0Vmlld01hbmFnZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ava/org/apache/pinot/segment/spi/IndexSegment.java](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&filepath=pinot-segment-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Fspi%2FIndexSegment.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL0luZGV4U2VnbWVudC5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18478?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d88887e) and HEAD (41591d0). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (d88887e) | HEAD (41591d0) |
   >|------|------|------|
   >|java-21|5|1|
   >|unittests|2|1|
   >|temurin|5|1|
   >|unittests2|1|0|
   >|integration|3|0|
   >|integration1|1|0|
   >|integration2|1|0|
   >|custom-integration1|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18478      +/-   ##
   ============================================
   - Coverage     63.68%   55.76%   -7.93%     
   + Complexity     1684      815     -869     
   ============================================
     Files          3262     2551     -711     
     Lines        199835   148347   -51488     
     Branches      31034    23974    -7060     
   ============================================
   - Hits         127266    82721   -44545     
   + Misses        62416    58540    -3876     
   + Partials      10153     7086    -3067     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-21](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.76% <9.52%> (-7.93%)` | :arrow_down: |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.76% <9.52%> (-7.93%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.76% <9.52%> (-7.93%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.76% <9.52%> (-0.02%)` | :arrow_down: |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18478?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Use upsert snapshot view in hasNoQueryableDocs to fix consistency-mode pruning [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #18478:
URL: https://github.com/apache/pinot/pull/18478


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org