You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/12/26 14:26:42 UTC

[2/5] kylin git commit: KYLIN-2217 fix a bug with GlobalDictionary

KYLIN-2217 fix a bug with GlobalDictionary


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/cf1aa6ce
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/cf1aa6ce
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/cf1aa6ce

Branch: refs/heads/yang22-hbase1.x
Commit: cf1aa6ce0ea42c8ebc684c68b2d6958382af0f0f
Parents: e3e42a0
Author: Yang Li <li...@apache.org>
Authored: Mon Dec 26 20:44:12 2016 +0800
Committer: Yang Li <li...@apache.org>
Committed: Mon Dec 26 20:44:12 2016 +0800

----------------------------------------------------------------------
 .../apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java  | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/cf1aa6ce/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java
index 776d750..a59e3ae 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java
@@ -128,6 +128,9 @@ public class FactDistinctColumnsReducer extends KylinReducer<SelfDefineSortableK
 
             // local build dict
             isReducerLocalBuildDict = config.isReducerLocalBuildDict();
+            if (cubeDesc.getDictionaryBuilderClass(col) != null) { // only works with default dictionary builder
+                isReducerLocalBuildDict = false;
+            }
             if (col != null && isReducerLocalBuildDict) {
                 builder = DictionaryGenerator.newDictionaryBuilder(col.getType());
                 builder.init(null, 0);