[GitHub] [airflow] XD-DENG commented on a change in pull request #11970: Unify user session lifetime configuration

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #11970:
URL: https://github.com/apache/airflow/pull/11970#discussion_r518703489



##########
File path: airflow/www/app.py
##########
@@ -66,8 +66,20 @@ def create_app(config=None, testing=False, app_name="Airflow"):
     flask_app = Flask(__name__)
     flask_app.secret_key = conf.get('webserver', 'SECRET_KEY')
 
-    session_lifetime_days = conf.getint('webserver', 'SESSION_LIFETIME_DAYS', fallback=30)
-    flask_app.config['PERMANENT_SESSION_LIFETIME'] = timedelta(days=session_lifetime_days)
+    default_session_lifetime_minutes = 43200
+    if conf.has_option('webserver', 'SESSION_LIFETIME_MINUTES'):
+        session_lifetime_minutes = conf.getint('webserver', 'SESSION_LIFETIME_MINUTES',
+                                               fallback=default_session_lifetime_minutes)
+    else:
+        warnings.warn('`SESSION_LIFETIME_DAYS` option from `webserver` section has been '

Review comment:
       Cool, we are aligned then.
   
   Take your time please for the implementation if you are busy. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org