You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by Xiao Wang <xw...@stevens.edu> on 2020/11/10 06:21:10 UTC

Refactoring opportunity in test code.

Hello Dubbo Community,

I find that Dubbo have some test classes inherit production classes to support testing. Since Dubbo is using Mockito framework I believe some of the test classes are redundant and can be replaced by leveraging the mocking framework. This could improve the readability for test code and decrease the coupling between test and production code.

I created a pull request for some test classes and provided corresponding refactoring solutions https://github.com/apache/dubbo/pull/6860/files

I also attached the Issue Link here: https://github.com/apache/dubbo/issues/6859

I look forward to hearing your opinions!

Best Regards,
Xiao