You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/17 02:29:45 UTC

[GitHub] [superset] hughhhh commented on a change in pull request #18722: feat: DBC-UI Globally available across the app 🌎

hughhhh commented on a change in pull request #18722:
URL: https://github.com/apache/superset/pull/18722#discussion_r808616539



##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -163,6 +211,13 @@ const RightMenu = ({
                     className="data-menu"
                     title={menuIconAndLabel(menu)}
                   >
+                    <Menu.Item key="connectDB">Connect Database</Menu.Item>
+                    {SHOW_GLOBAL_GSHEETS && (
+                      <Menu.Item key="connectGSheets">

Review comment:
       change these to enums




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org