You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "ywj1352 (via GitHub)" <gi...@apache.org> on 2023/02/16 09:39:09 UTC

[GitHub] [shenyu] ywj1352 opened a new pull request, #4392: Task[#4379] Plugin upload hot load into Shenyu

ywj1352 opened a new pull request, #4392:
URL: https://github.com/apache/shenyu/pull/4392

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] codecov-commenter commented on pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4392:
URL: https://github.com/apache/shenyu/pull/4392#issuecomment-1434002675

   # [Codecov](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4392](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a98e827) into [master](https://codecov.io/gh/apache/shenyu/commit/7991582bb4d849edd313d12f757eb9532eec6c0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7991582) will **decrease** coverage by `0.23%`.
   > The diff coverage is `20.68%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4392      +/-   ##
   ============================================
   - Coverage     68.33%   68.11%   -0.23%     
   + Complexity     7519     7517       -2     
   ============================================
     Files          1020     1020              
     Lines         28849    28913      +64     
     Branches       2576     2579       +3     
   ============================================
   - Hits          19714    19694      -20     
   - Misses         7588     7673      +85     
   + Partials       1547     1546       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../java/org/apache/shenyu/common/dto/PluginData.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vUGx1Z2luRGF0YS5qYXZh) | `52.50% <0.00%> (-11.14%)` | :arrow_down: |
   | [...g/apache/shenyu/web/loader/ShenyuPluginLoader.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luTG9hZGVyLmphdmE=) | `59.66% <7.69%> (-15.16%)` | :arrow_down: |
   | [...rg/apache/shenyu/web/handler/ShenyuWebHandler.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9oYW5kbGVyL1NoZW55dVdlYkhhbmRsZXIuamF2YQ==) | `91.30% <40.00%> (-4.09%)` | :arrow_down: |
   | [.../apache/shenyu/web/loader/ShenyuLoaderService.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1TG9hZGVyU2VydmljZS5qYXZh) | `72.41% <73.33%> (-18.07%)` | :arrow_down: |
   | [...pringboot/starter/gateway/ShenyuConfiguration.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItZ2F0ZXdheS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9nYXRld2F5L1NoZW55dUNvbmZpZ3VyYXRpb24uamF2YQ==) | `91.30% <100.00%> (ø)` | |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `58.51% <0.00%> (-11.71%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `21.27% <0.00%> (-6.39%)` | :arrow_down: |
   | [...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9SZXdyaXRlUGx1Z2luLmphdmE=) | `66.66% <0.00%> (-5.56%)` | :arrow_down: |
   | [.../plugin/grpc/loadbalance/AbstractLoadBalancer.java](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9BYnN0cmFjdExvYWRCYWxhbmNlci5qYXZh) | `70.65% <0.00%> (-5.44%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/shenyu/pull/4392?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] ywj1352 closed pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "ywj1352 (via GitHub)" <gi...@apache.org>.
ywj1352 closed pull request #4392: Task[#4379] Plugin upload hot load into Shenyu
URL: https://github.com/apache/shenyu/pull/4392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] ywj1352 closed pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "ywj1352 (via GitHub)" <gi...@apache.org>.
ywj1352 closed pull request #4392: Task[#4379] Plugin upload hot load into Shenyu
URL: https://github.com/apache/shenyu/pull/4392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] yu199195 commented on a diff in pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 commented on code in PR #4392:
URL: https://github.com/apache/shenyu/pull/4392#discussion_r1112510976


##########
shenyu-common/src/main/java/org/apache/shenyu/common/dto/PluginData.java:
##########
@@ -35,9 +35,11 @@ public class PluginData {
     private String role;
 
     private Boolean enabled;
-    
+
     private Integer sort;
 
+    private String jarResourcesBase64;

Review Comment:
   used jarResources



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] ywj1352 commented on a diff in pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "ywj1352 (via GitHub)" <gi...@apache.org>.
ywj1352 commented on code in PR #4392:
URL: https://github.com/apache/shenyu/pull/4392#discussion_r1112607178


##########
shenyu-common/src/main/java/org/apache/shenyu/common/dto/PluginData.java:
##########
@@ -35,9 +35,11 @@ public class PluginData {
     private String role;
 
     private Boolean enabled;
-    
+
     private Integer sort;
 
+    private String jarResourcesBase64;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] ywj1352 commented on pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "ywj1352 (via GitHub)" <gi...@apache.org>.
ywj1352 commented on PR #4392:
URL: https://github.com/apache/shenyu/pull/4392#issuecomment-1473452856

   ![image](https://user-images.githubusercontent.com/31105009/225859750-6bb51243-0da5-4ee3-b50b-e57af13949df.png)
   it works in local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] mahaitao617 merged pull request #4392: Task[#4379] Plugin upload hot load into Shenyu

Posted by "mahaitao617 (via GitHub)" <gi...@apache.org>.
mahaitao617 merged PR #4392:
URL: https://github.com/apache/shenyu/pull/4392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org