You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "viviennes7 (GitHub)" <gi...@apache.org> on 2019/01/24 06:41:21 UTC

[GitHub] [incubator-dubbo-spring-boot-project] viviennes7 opened pull request #405: Missing @Override annotation


[ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-spring-boot-project] viviennes7 closed pull request #405: Missing @Override annotation

Posted by "viviennes7 (GitHub)" <gi...@apache.org>.
[ pull request closed by viviennes7 ]

[ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-spring-boot-project] codecov-io commented on issue #405: Missing @Override annotation

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=h1) Report
> Merging [#405](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/commit/ac4eeacff0425a3840b1fd578ceed94ff3026754?src=pr&el=desc) will **increase** coverage by `0.5%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405/graphs/tree.svg?width=650&token=kUfQHeQoc2&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##             master     #405     +/-   ##
===========================================
+ Coverage     88.22%   88.72%   +0.5%     
  Complexity      129      129             
===========================================
  Files            19       19             
  Lines           399      399             
  Branches         48       48             
===========================================
+ Hits            352      354      +2     
+ Misses           26       24      -2     
  Partials         21       21
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ntext/event/AwaitingNonWebApplicationListener.java](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405/diff?src=pr&el=tree#diff-ZHViYm8tc3ByaW5nLWJvb3QtYXV0b2NvbmZpZ3VyZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2Jvb3QvZHViYm8vY29udGV4dC9ldmVudC9Bd2FpdGluZ05vbldlYkFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `86.53% <0%> (+3.84%)` | `22% <0%> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=footer). Last update [ac4eeac...55d7508](https://codecov.io/gh/apache/incubator-dubbo-spring-boot-project/pull/405?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/405 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org