You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/04/13 18:30:43 UTC

[kudu-CR] [docs] Add ninja to make site.sh

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19729


Change subject: [docs] Add ninja to make_site.sh
......................................................................

[docs] Add ninja to make_site.sh

If ninja is present on the system, use it to build Kudu. The command
"rm -rf CMakeCache CMakeFiles/" clears the build folder incorrectly.
Rather than CMakeCache one has to clear CMakeCache.txt, else cmake won't
pick up the specified generator. (cmake error: Does not match the
generator used previously)

Change-Id: Ic3a5cb1252554c2f5ed137a6053376c435775e4b
---
M docs/support/scripts/make_site.sh
1 file changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/19729/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3a5cb1252554c2f5ed137a6053376c435775e4b
Gerrit-Change-Number: 19729
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] [docs] Add ninja to make site.sh

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19729 )

Change subject: [docs] Add ninja to make_site.sh
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3a5cb1252554c2f5ed137a6053376c435775e4b
Gerrit-Change-Number: 19729
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 21:23:19 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] Add ninja to make site.sh

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19729 )

Change subject: [docs] Add ninja to make_site.sh
......................................................................


Patch Set 1: Code-Review+1

nit: Could you add some details, what OpSystems did you test this on?


-- 
To view, visit http://gerrit.cloudera.org:8080/19729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3a5cb1252554c2f5ed137a6053376c435775e4b
Gerrit-Change-Number: 19729
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 20:05:11 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] Add ninja to make site.sh

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19729 )

Change subject: [docs] Add ninja to make_site.sh
......................................................................

[docs] Add ninja to make_site.sh

If ninja is present on the system, use it to build Kudu. The command
"rm -rf CMakeCache CMakeFiles/" clears the build folder incorrectly.
Rather than CMakeCache one has to clear CMakeCache.txt, else cmake won't
pick up the specified generator. (cmake error: Does not match the
generator used previously)

Change-Id: Ic3a5cb1252554c2f5ed137a6053376c435775e4b
Reviewed-on: http://gerrit.cloudera.org:8080/19729
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M docs/support/scripts/make_site.sh
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Zoltan Chovan: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3a5cb1252554c2f5ed137a6053376c435775e4b
Gerrit-Change-Number: 19729
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>