You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "codope (via GitHub)" <gi...@apache.org> on 2023/01/29 15:55:43 UTC
[GitHub] [hudi] codope opened a new pull request, #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
codope opened a new pull request, #7787:
URL: https://github.com/apache/hudi/pull/7787
### Change Logs
Schema reconciliation is turned off by default. We should not allow dropping columns by default unless schema reconciliation is on. This PR adds a config and schema compatibility check to that effect.
### Impact
The default behavior is:
- Addition of columns is allowed.
- Type promotion is allowed.
- Dropping columns not allowed.
- Renaming columns not allowed.
### Risk level (write none, low medium or high below)
medium
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1410768832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8849a731a979b687f490674e7fc15f8301947b27 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804)
* 41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409282831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 555d916d59eb755d6495cf4385a260f0c8edce1e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766)
* 4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on code in PR #7787:
URL: https://github.com/apache/hudi/pull/7787#discussion_r1090073190
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -88,7 +106,7 @@ public static boolean isCompatibleProjectionOf(Schema sourceSchema, Schema targe
private static boolean isAtomicSchemasCompatible(Schema oneAtomicType, Schema anotherAtomicType) {
// NOTE: Checking for compatibility of atomic types, we should ignore their
// corresponding fully-qualified names (as irrelevant)
- return isSchemaCompatible(oneAtomicType, anotherAtomicType, false);
+ return isSchemaCompatible(oneAtomicType, anotherAtomicType, false, true);
Review Comment:
B/c this check is validating whether one schema is the projection of another
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -217,31 +217,6 @@ object HoodieSparkSqlWriter {
}
}
- // NOTE: Target writer's schema is deduced based on
- // - Source's schema
- // - Existing table's schema (including its Hudi's [[InternalSchema]] representation)
- val writerSchema = deduceWriterSchema(sourceSchema, latestTableSchemaOpt, internalSchemaOpt, parameters)
Review Comment:
This code has moved to avoid running it for operations like delete/delete_partition
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -217,31 +217,6 @@ object HoodieSparkSqlWriter {
}
}
- // NOTE: Target writer's schema is deduced based on
- // - Source's schema
- // - Existing table's schema (including its Hudi's [[InternalSchema]] representation)
- val writerSchema = deduceWriterSchema(sourceSchema, latestTableSchemaOpt, internalSchemaOpt, parameters)
-
- validateSchemaForHoodieIsDeleted(writerSchema)
-
- // NOTE: PLEASE READ CAREFULLY BEFORE CHANGING THIS
- // We have to register w/ Kryo all of the Avro schemas that might potentially be used to decode
- // records into Avro format. Otherwise, Kryo wouldn't be able to apply an optimization allowing
- // it to avoid the need to ser/de the whole schema along _every_ Avro record
- val targetAvroSchemas = sourceSchema +: writerSchema +: latestTableSchemaOpt.toSeq
Review Comment:
This code is actually a misnomer: unfortunately after Spark Session is started it's impossible to register Kryo schemas with it (therefore this code is removed to unblock writer schema handling)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407824603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3718611768f4c0b22ea04bc1520dce373dac34cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746)
* eda0a45547eecaf84a1dc5e0000c4e5b2d16d267 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409641937
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781)
* a930137a8435863ad4b01997b731895328c0fa59 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1408161948
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 819dd49cb6060031b722c193826797e488fcbf7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753)
* 555d916d59eb755d6495cf4385a260f0c8edce1e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1410156937
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8849a731a979b687f490674e7fc15f8301947b27 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409273253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 555d916d59eb755d6495cf4385a260f0c8edce1e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766)
* 4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409493223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1410757353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8849a731a979b687f490674e7fc15f8301947b27 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804)
* 41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407827718
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3718611768f4c0b22ea04bc1520dce373dac34cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746)
* eda0a45547eecaf84a1dc5e0000c4e5b2d16d267 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752)
* 819dd49cb6060031b722c193826797e488fcbf7c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1408418657
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 555d916d59eb755d6495cf4385a260f0c8edce1e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1411422598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
}, {
"hash" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823",
"triggerID" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"triggerType" : "PUSH"
}, {
"hash" : "f75bc675317126236363e3c0fd0ee1fa91aa0478",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f75bc675317126236363e3c0fd0ee1fa91aa0478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe056bb626afe4ae03eeb0fd2a9c2108e81daca2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823)
* f75bc675317126236363e3c0fd0ee1fa91aa0478 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1411613803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
}, {
"hash" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823",
"triggerID" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"triggerType" : "PUSH"
}, {
"hash" : "f75bc675317126236363e3c0fd0ee1fa91aa0478",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14833",
"triggerID" : "f75bc675317126236363e3c0fd0ee1fa91aa0478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f75bc675317126236363e3c0fd0ee1fa91aa0478 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14833)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407719980
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3718611768f4c0b22ea04bc1520dce373dac34cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407947389
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 819dd49cb6060031b722c193826797e488fcbf7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1411338571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
}, {
"hash" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823",
"triggerID" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe056bb626afe4ae03eeb0fd2a9c2108e81daca2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1411200578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
}, {
"hash" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820)
* fe056bb626afe4ae03eeb0fd2a9c2108e81daca2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1411465963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
}, {
"hash" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823",
"triggerID" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"triggerType" : "PUSH"
}, {
"hash" : "f75bc675317126236363e3c0fd0ee1fa91aa0478",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14833",
"triggerID" : "f75bc675317126236363e3c0fd0ee1fa91aa0478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe056bb626afe4ae03eeb0fd2a9c2108e81daca2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823)
* f75bc675317126236363e3c0fd0ee1fa91aa0478 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14833)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407830905
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda0a45547eecaf84a1dc5e0000c4e5b2d16d267 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752)
* 819dd49cb6060031b722c193826797e488fcbf7c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1410979827
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #7787:
URL: https://github.com/apache/hudi/pull/7787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407757737
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3718611768f4c0b22ea04bc1520dce373dac34cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409646609
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781)
* a930137a8435863ad4b01997b731895328c0fa59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409843915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781)
* a930137a8435863ad4b01997b731895328c0fa59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790)
* 8849a731a979b687f490674e7fc15f8301947b27 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1409850396
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a930137a8435863ad4b01997b731895328c0fa59 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790)
* 8849a731a979b687f490674e7fc15f8301947b27 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1408172007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 819dd49cb6060031b722c193826797e488fcbf7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753)
* 555d916d59eb755d6495cf4385a260f0c8edce1e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1408128144
Addressed my comments and pushed an update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407801354
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3718611768f4c0b22ea04bc1520dce373dac34cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746)
* eda0a45547eecaf84a1dc5e0000c4e5b2d16d267 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1407718164
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3718611768f4c0b22ea04bc1520dce373dac34cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #7787:
URL: https://github.com/apache/hudi/pull/7787#discussion_r1090028568
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -227,6 +227,14 @@ public class HoodieWriteConfig extends HoodieConfig {
.defaultValue("true")
.withDocumentation("Validate the schema used for the write against the latest schema, for backwards compatibility.");
+ public static final ConfigProperty<String> SCHEMA_ALLOW_DROP_COLUMNS = ConfigProperty
Review Comment:
let's define it as a string and not as config property. we don't want to expose this in our configurations page.
Or we need to come up w/ a way to tag internal configs so that we can fix our config docs generation.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestTableSchemaEvolution.java:
##########
@@ -230,19 +240,27 @@ public void testMORTable() throws Exception {
// Now try updating w/ the original schema (should succeed)
client = getHoodieWriteClient(hoodieWriteConfig);
- updateBatch(hoodieWriteConfig, client, "009", "008", Option.empty(),
- initCommitTime, numUpdateRecords, SparkRDDWriteClient::upsert, false, false, numUpdateRecords, 4 * numRecords, 9);
+ try {
+ updateBatch(hoodieWriteConfig, client, "009", "008", Option.empty(),
+ initCommitTime, numUpdateRecords, SparkRDDWriteClient::upsert, false, false, numUpdateRecords, 4 * numRecords, 9);
+ } catch (HoodieUpsertException e) {
Review Comment:
similar comment as above
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestBasicSchemaEvolution.scala:
##########
@@ -270,7 +277,10 @@ class TestBasicSchemaEvolution extends HoodieClientTestBase with ScalaAssertionS
appendData(fourthSchema, fourthBatch)
}
} else {
- appendData(fourthSchema, fourthBatch)
+ assertThrows(classOf[SchemaCompatibilityException]) {
+ appendData(fourthSchema, fourthBatch)
+ }
+ appendData(fourthSchema, fourthBatch, shouldAllowDroppedColumns = true)
Review Comment:
same here
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestTableSchemaEvolution.java:
##########
@@ -266,19 +284,24 @@ public void testCopyOnWriteTable() throws Exception {
checkReadRecords("000", numRecords);
// Inserting records w/ new evolved schema (w/ tip column dropped)
- HoodieWriteConfig hoodieDevolvedWriteConfig = getWriteConfig(TRIP_EXAMPLE_SCHEMA_EVOLVED_COL_DROPPED);
+ HoodieWriteConfig hoodieDevolvedWriteConfig = getWriteConfig(TRIP_EXAMPLE_SCHEMA_EVOLVED_COL_DROPPED, shouldAllowDroppedColumns);
client = getHoodieWriteClient(hoodieDevolvedWriteConfig);
final List<HoodieRecord> failedRecords = generateInsertsWithSchema("004", numRecords, TRIP_EXAMPLE_SCHEMA_EVOLVED_COL_DROPPED);
- writeBatch(client, "004", "003", Option.empty(), "003", numRecords,
- (String s, Integer a) -> failedRecords, SparkRDDWriteClient::insert, true, numRecords, numRecords * 2, 1, false);
+ try {
+ writeBatch(client, "004", "003", Option.empty(), "003", numRecords,
+ (String s, Integer a) -> failedRecords, SparkRDDWriteClient::insert, true, numRecords, numRecords * 2, 1, false);
+ } catch (HoodieInsertException e) {
+ assertFalse(shouldAllowDroppedColumns);
Review Comment:
ditto
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -416,7 +419,8 @@ object HoodieSparkSqlWriter {
case None =>
// In case schema reconciliation is enabled we will employ (legacy) reconciliation
// strategy to produce target writer's schema (see definition below)
- val (reconciledSchema, isCompatible) = reconcileSchemasLegacy(latestTableSchema, canonicalizedSourceSchema)
+ // NOTE: if schema reconciliation is turned on, then we should allow columns to be dropped
+ val (reconciledSchema, isCompatible) = reconcileSchemasLegacy(latestTableSchema, canonicalizedSourceSchema, shouldAllowDroppedColumns = true)
Review Comment:
why setting the value for shouldAllowDroppedColumns to true ? we do derive the value at L408 right ?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestTableSchemaEvolution.java:
##########
@@ -194,20 +199,25 @@ public void testMORTable() throws Exception {
checkReadRecords("000", numRecords);
// Insert with evolved schema (column dropped) is allowed
- HoodieWriteConfig hoodieDevolvedWriteConfig = getWriteConfig(TRIP_EXAMPLE_SCHEMA_EVOLVED_COL_DROPPED);
+ HoodieWriteConfig hoodieDevolvedWriteConfig = getWriteConfig(TRIP_EXAMPLE_SCHEMA_EVOLVED_COL_DROPPED, shouldAllowDroppedColumns);
client = getHoodieWriteClient(hoodieDevolvedWriteConfig);
final List<HoodieRecord> failedRecords = generateInsertsWithSchema("005", numRecords, TRIP_EXAMPLE_SCHEMA_EVOLVED_COL_DROPPED);
// We cannot use insertBatch directly here because we want to insert records
// with a evolved schema and insertBatch inserts records using the TRIP_EXAMPLE_SCHEMA.
- writeBatch(client, "005", "004", Option.empty(), "003", numRecords,
- (String s, Integer a) -> failedRecords, SparkRDDWriteClient::insert, false, numRecords, 2 * numRecords, 5, false);
+ try {
+ writeBatch(client, "005", "004", Option.empty(), "003", numRecords,
+ (String s, Integer a) -> failedRecords, SparkRDDWriteClient::insert, false, numRecords, 2 * numRecords, 5, false);
+ } catch (HoodieInsertException e) {
Review Comment:
after L209, we should also do, before catch block
```
assertTrue(shouldAllowDroppedColumns);
```
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -36,10 +37,17 @@ public class AvroSchemaUtils {
private AvroSchemaUtils() {}
/**
- * See {@link #isSchemaCompatible(Schema, Schema, boolean)} doc for more details
+ * See {@link #isSchemaCompatible(Schema, Schema, boolean, boolean)} doc for more details
*/
public static boolean isSchemaCompatible(Schema prevSchema, Schema newSchema) {
- return isSchemaCompatible(prevSchema, newSchema, true);
+ return isSchemaCompatible(prevSchema, newSchema, true, false);
Review Comment:
instead of false, can we do SCHEMA_ALLOW_DROP_COLUMNS.defaultValue()
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -50,10 +58,20 @@ public static boolean isSchemaCompatible(Schema prevSchema, Schema newSchema) {
* @param newSchema new instance of the schema
* @param checkNaming controls whether schemas fully-qualified names should be checked
*/
- public static boolean isSchemaCompatible(Schema prevSchema, Schema newSchema, boolean checkNaming) {
+ public static boolean isSchemaCompatible(Schema prevSchema, Schema newSchema, boolean checkNaming, boolean shouldAllowDroppedColumns) {
// NOTE: We're establishing compatibility of the {@code prevSchema} and {@code newSchema}
// as following: {@code newSchema} is considered compatible to {@code prevSchema},
// iff data written using {@code prevSchema} could be read by {@code newSchema}
+
+ if (!shouldAllowDroppedColumns) {
+ // Check that each field in the oldSchema can be populated in the newSchema
+ for (final Schema.Field oldSchemaField : prevSchema.getFields()) {
Review Comment:
we can simplify as
```
boolean isAnyColDropped = prevSchema.getFields().stream()
.map(oldSchemaField -> SchemaCompatibility.lookupWriterField(newSchema, oldSchemaField))
.filter(Objects::isNull).findAny().isPresent();
```
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -88,7 +106,7 @@ public static boolean isCompatibleProjectionOf(Schema sourceSchema, Schema targe
private static boolean isAtomicSchemasCompatible(Schema oneAtomicType, Schema anotherAtomicType) {
// NOTE: Checking for compatibility of atomic types, we should ignore their
// corresponding fully-qualified names (as irrelevant)
- return isSchemaCompatible(oneAtomicType, anotherAtomicType, false);
+ return isSchemaCompatible(oneAtomicType, anotherAtomicType, false, true);
Review Comment:
why we are setting true here as default for shouldAllowDroppedColumns?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestBasicSchemaEvolution.scala:
##########
@@ -217,7 +217,14 @@ class TestBasicSchemaEvolution extends HoodieClientTestBase with ScalaAssertionS
Row("8", "Ron", "14", 1, 1),
Row("9", "Germiona", "16", 1, 1))
- appendData(thirdSchema, thirdBatch)
+ if (shouldReconcileSchema) {
Review Comment:
lets fix comments in L204.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestTableSchemaEvolution.java:
##########
@@ -299,9 +322,13 @@ public void testCopyOnWriteTable() throws Exception {
// Now try updating w/ the original schema (should succeed)
client = getHoodieWriteClient(hoodieWriteConfig);
- updateBatch(hoodieWriteConfig, client, "008", "007", Option.empty(),
- initCommitTime, numUpdateRecords, SparkRDDWriteClient::upsert, false, true,
- numUpdateRecords, 3 * numRecords, 8);
+ try {
+ updateBatch(hoodieWriteConfig, client, "008", "007", Option.empty(),
+ initCommitTime, numUpdateRecords, SparkRDDWriteClient::upsert, false, true,
+ numUpdateRecords, 3 * numRecords, 8);
+ } catch (HoodieUpsertException e) {
+ assertFalse(shouldAllowDroppedColumns);
Review Comment:
ditto
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestBasicSchemaEvolution.scala:
##########
@@ -217,7 +217,14 @@ class TestBasicSchemaEvolution extends HoodieClientTestBase with ScalaAssertionS
Row("8", "Ron", "14", 1, 1),
Row("9", "Germiona", "16", 1, 1))
- appendData(thirdSchema, thirdBatch)
+ if (shouldReconcileSchema) {
+ appendData(thirdSchema, thirdBatch)
+ } else {
+ assertThrows(classOf[SchemaCompatibilityException]) {
+ appendData(thirdSchema, thirdBatch)
+ }
+ appendData(thirdSchema, thirdBatch, shouldAllowDroppedColumns = true)
Review Comment:
again, last arg should just be `shouldAllowDroppedColumns` and not `shouldAllowDroppedColumns = true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7787: [HUDI-5646] Guard dropping columns by a config, do not allow by default
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7787:
URL: https://github.com/apache/hudi/pull/7787#issuecomment-1411206982
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14746",
"triggerID" : "3718611768f4c0b22ea04bc1520dce373dac34cb",
"triggerType" : "PUSH"
}, {
"hash" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14752",
"triggerID" : "eda0a45547eecaf84a1dc5e0000c4e5b2d16d267",
"triggerType" : "PUSH"
}, {
"hash" : "819dd49cb6060031b722c193826797e488fcbf7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14753",
"triggerID" : "819dd49cb6060031b722c193826797e488fcbf7c",
"triggerType" : "PUSH"
}, {
"hash" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14766",
"triggerID" : "555d916d59eb755d6495cf4385a260f0c8edce1e",
"triggerType" : "PUSH"
}, {
"hash" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14781",
"triggerID" : "4a25ef8aaf5415ea6a918b7f32c5f3a84597ddec",
"triggerType" : "PUSH"
}, {
"hash" : "a930137a8435863ad4b01997b731895328c0fa59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14790",
"triggerID" : "a930137a8435863ad4b01997b731895328c0fa59",
"triggerType" : "PUSH"
}, {
"hash" : "8849a731a979b687f490674e7fc15f8301947b27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14804",
"triggerID" : "8849a731a979b687f490674e7fc15f8301947b27",
"triggerType" : "PUSH"
}, {
"hash" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820",
"triggerID" : "41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d",
"triggerType" : "PUSH"
}, {
"hash" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823",
"triggerID" : "fe056bb626afe4ae03eeb0fd2a9c2108e81daca2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41584f7f3aeb97a5315d3dd2dd8c49c7c82aa71d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14820)
* fe056bb626afe4ae03eeb0fd2a9c2108e81daca2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14823)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org