You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/19 05:14:32 UTC
[GitHub] [spark] rxin opened a new pull request, #39120: [WIP] Make "rule id not found" error slightly easier to debug.
rxin opened a new pull request, #39120:
URL: https://github.com/apache/spark/pull/39120
### What changes were proposed in this pull request?
It was super confusing to me when adding a new rule that I bumped into the rule id error. This patch updates the error messages to tell developers that they should update the appropriate place in code to fix the error.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I ran it manually locally and the error messages were updated. I'm however not sure yet if we have test cases depending on the exact output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39120: [WIP] Make "rule id not found" error slightly easier to debug.
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #39120:
URL: https://github.com/apache/spark/pull/39120#discussion_r1052127797
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4298,7 +4298,7 @@
},
"_LEGACY_ERROR_TEMP_2175" : {
Review Comment:
From the intention of the error message, I think we should directly use `SparkException#internalError` to replace this error class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #39120: [WIP] Make "rule id not found" error slightly easier to debug.
Posted by GitBox <gi...@apache.org>.
sigmod commented on PR #39120:
URL: https://github.com/apache/spark/pull/39120#issuecomment-1357121969
>> I'm however not sure yet if we have test cases depending on the exact output.
I don't think we have a test case for the error message.
The error message indicates a bug - the rule use RuleId-based pruning but doesn't register an id in RuleIdCollection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39120: [WIP] Make "rule id not found" error slightly easier to debug.
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #39120:
URL: https://github.com/apache/spark/pull/39120#discussion_r1051827256
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4298,7 +4298,7 @@
},
"_LEGACY_ERROR_TEMP_2175" : {
Review Comment:
This special error class name means it's not a public error. This is just a temporary name to speed up error migration. Eventually it will be either removed if it's indeed an internal error, or renamed to an offical name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #39120: [SPARK-41588][SQL] Make "rule id not found" error slightly easier to debug.
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #39120: [SPARK-41588][SQL] Make "rule id not found" error slightly easier to debug.
URL: https://github.com/apache/spark/pull/39120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39120: [SPARK-41588][SQL] Make "rule id not found" error slightly easier to debug.
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39120:
URL: https://github.com/apache/spark/pull/39120#issuecomment-1358536324
@rxin Thanks, merging to the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org