You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/03/12 21:21:55 UTC

Review Request: [OOZIE-1263] Fix few HCat dependency check issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9881/
-----------------------------------------------------------

Review request for oozie.


Description
-------

Fixed the following issues:
1) If the recovery service queued CoordPushCheck and it was due for Timeout, it resolves the push dependencies but misses resolving latest nor does it queue timeout. So it stays in WAITING till RecoveryService kicks in and queues CoordActionInputCheck
2) HCatURIHandler messages do not have actionid
3) Duplicate action ids were stored in Cache when recovery service kicked with lower interval
4) Removed actionID from the log messages as it was duplicating the info in log prefix.
5) Made the ehcache cache per hcat server to avoid duplicating server name in each cache entry key.


This addresses bug OOZIE-1263.
    https://issues.apache.org/jira/browse/OOZIE-1263


Diffs
-----

  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingAction.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingActions.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1455302 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1455302 

Diff: https://reviews.apache.org/r/9881/diff/


Testing
-------

Unit tests added.


Thanks,

Rohini Palaniswamy

Re: Review Request: [OOZIE-1263] Fix few HCat dependency check issues

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9881/#review17779
-----------------------------------------------------------

Ship it!


Ship It!

- Virag Kothari


On March 12, 2013, 8:21 p.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9881/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 8:21 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Fixed the following issues:
> 1) If the recovery service queued CoordPushCheck and it was due for Timeout, it resolves the push dependencies but misses resolving latest nor does it queue timeout. So it stays in WAITING till RecoveryService kicks in and queues CoordActionInputCheck
> 2) HCatURIHandler messages do not have actionid
> 3) Duplicate action ids were stored in Cache when recovery service kicked with lower interval
> 4) Removed actionID from the log messages as it was duplicating the info in log prefix.
> 5) Made the ehcache cache per hcat server to avoid duplicating server name in each cache entry key.
> 
> 
> This addresses bug OOZIE-1263.
>     https://issues.apache.org/jira/browse/OOZIE-1263
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingAction.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/dependency/hcat/WaitingActions.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1455302 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1455302 
> 
> Diff: https://reviews.apache.org/r/9881/diff/
> 
> 
> Testing
> -------
> 
> Unit tests added.
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>